From: Stefan Berger <stefanb@linux.ibm.com>
To: James Bottomley <jejb@linux.ibm.com>, qemu-devel@nongnu.org
Cc: "Daniel P . Berrangé" <berrange@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>
Subject: Re: [PATCH v3 0/2] tpm: add mssim backend
Date: Mon, 19 Dec 2022 08:51:35 -0500 [thread overview]
Message-ID: <08142e4d-0210-627d-98ea-6f094979ebcc@linux.ibm.com> (raw)
In-Reply-To: <20221219131344.18909-1-jejb@linux.ibm.com>
On 12/19/22 08:13, James Bottomley wrote:
> From: James Bottomley <James.Bottomley@HansenPartnership.com>
>
> The requested feedback was to convert the tpmdev handler to being json
> based, which requires rethreading all the backends. The good news is
> this reduced quite a bit of code (especially as I converted it to
> error_fatal handling as well, which removes the return status
> threading). The bad news is I can't test any of the conversions.
> swtpm still isn't building on opensuse and, apparently, passthrough
The package seems to be available: https://software.opensuse.org/package/swtpm
I'll get to looking at this in more depth once I am back in office.
Stefan
> doesn't like my native TPM because it doesn't allow cancellation.
>
> v3 pulls out more unneeded code in the visitor conversion, makes
> migration work on external state preservation of the simulator and
> adds documentation
>
> James
>
> ---
>
> James Bottomley (2):
> tpm: convert tpmdev options processing to new visitor format
> tpm: add backend for mssim
>
> MAINTAINERS | 6 +
> backends/tpm/Kconfig | 5 +
> backends/tpm/meson.build | 1 +
> backends/tpm/tpm_emulator.c | 35 ++---
> backends/tpm/tpm_mssim.c | 264 +++++++++++++++++++++++++++++++++
> backends/tpm/tpm_mssim.h | 43 ++++++
> backends/tpm/tpm_passthrough.c | 37 ++---
> docs/specs/tpm.rst | 35 +++++
> include/sysemu/tpm.h | 4 +-
> include/sysemu/tpm_backend.h | 2 +-
> monitor/hmp-cmds.c | 11 +-
> qapi/tpm.json | 37 ++---
> softmmu/tpm.c | 90 +++++------
> softmmu/vl.c | 19 +--
> 14 files changed, 449 insertions(+), 140 deletions(-)
> create mode 100644 backends/tpm/tpm_mssim.c
> create mode 100644 backends/tpm/tpm_mssim.h
>
next prev parent reply other threads:[~2022-12-19 13:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 13:13 [PATCH v3 0/2] tpm: add mssim backend James Bottomley
2022-12-19 13:13 ` [PATCH v3 1/2] tpm: convert tpmdev options processing to new visitor format James Bottomley
2022-12-21 16:32 ` Daniel P. Berrangé
2022-12-21 20:31 ` James Bottomley
2022-12-19 13:13 ` [PATCH v3 2/2] tpm: add backend for mssim James Bottomley
2022-12-19 13:51 ` Stefan Berger [this message]
2022-12-19 13:55 ` [PATCH v3 0/2] tpm: add mssim backend James Bottomley
2022-12-19 14:15 ` Stefan Berger
2022-12-19 14:17 ` James Bottomley
2022-12-19 15:16 ` Stefan Berger
2022-12-19 15:21 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08142e4d-0210-627d-98ea-6f094979ebcc@linux.ibm.com \
--to=stefanb@linux.ibm.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=jejb@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).