From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A58DAC433F5 for ; Mon, 20 Sep 2021 16:48:57 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6F0F86127B for ; Mon, 20 Sep 2021 16:48:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6F0F86127B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:48870 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSMTQ-0003zF-KC for qemu-devel@archiver.kernel.org; Mon, 20 Sep 2021 12:48:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39024) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSM9T-0006gV-3X for qemu-devel@nongnu.org; Mon, 20 Sep 2021 12:28:19 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:27682) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSM9O-00088c-GI for qemu-devel@nongnu.org; Mon, 20 Sep 2021 12:28:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632155293; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D3TekfOIZuwbV5StCzYTTlbMrwMo9h/VmXf9CiJ57Lk=; b=ACbowlYWY8KBF9mjkKYfK4CqQqZ7ZuQ+PrPJgrRV/gpiz356BgIvKEWt2xPz91WtOlngfT eWYkD9H9ZI4POoA0hl7ueEZUTI1j+8NVuR0BrJEuK2VxteiIMhS7gKpV87eB6nqRpUGtFM 4Xy0R7p/+yqkN3ttH5DuQlwWcPPvTzo= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-22-AFwv3-tFO7-S1WbjIGGS7A-1; Mon, 20 Sep 2021 12:28:12 -0400 X-MC-Unique: AFwv3-tFO7-S1WbjIGGS7A-1 Received: by mail-wr1-f71.google.com with SMTP id q14-20020a5d574e000000b00157b0978ddeso6559229wrw.5 for ; Mon, 20 Sep 2021 09:28:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=D3TekfOIZuwbV5StCzYTTlbMrwMo9h/VmXf9CiJ57Lk=; b=IUXwpZDcPh03aX91GjuxcEWIOswrXzdWdZ2buj+eTJwf2wjXsptrio2F9ORPHCkVAg EOWLr8l2q74hvxfnBxD4uWyDndveX4C5qYBF/fxZ57PZwmPpSWldv0cTch4skp6CfdKn PB6AVNwlUMNHfkWToLVE5hhbK36WNwj1fPodbDGq0l+zmCsEC9y1wECynGrRB8gpJKuh Aayjvud/bbiZQAtT5E86LhLul9l4UtimvdWLw3qdMB/43inyh7CV9wdhd0NHp/2XABgM 6R2VSTDMCAm3oHajU4zDRi5UYKwA0gLF3dYTU7o3CSVFdYbRHX7ZZVOSq6VNYN/jxBPD /NCQ== X-Gm-Message-State: AOAM532993O9csjhKb/L/ld93B8ZjoTWT1oxhLTi2FmfWUKzZimM6t5j ws3niMBiClh/6sueUoKZ830uMXMZS8B+E3JXCZvJ89sHEMfxdjcWjfCK0nWcILNGjRIIAhqIOiH fILGQabIllCN6rTY= X-Received: by 2002:adf:e485:: with SMTP id i5mr28917130wrm.22.1632155291548; Mon, 20 Sep 2021 09:28:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzgrnJzru5LGlMXw9jyXm1fizh3gOOCRkUBcmjfyxYlCT29Xr/NQvC2mSCzXO9hQbbLymYhLg== X-Received: by 2002:adf:e485:: with SMTP id i5mr28917111wrm.22.1632155291364; Mon, 20 Sep 2021 09:28:11 -0700 (PDT) Received: from ?IPv6:2a01:e0a:59e:9d80:527b:9dff:feef:3874? ([2a01:e0a:59e:9d80:527b:9dff:feef:3874]) by smtp.gmail.com with ESMTPSA id d70sm6152wmd.3.2021.09.20.09.28.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Sep 2021 09:28:10 -0700 (PDT) Subject: Re: [PATCH v3 08/35] acpi: build_mcfg: use acpi_table_begin()/acpi_table_end() instead of build_header() To: Igor Mammedov , qemu-devel@nongnu.org References: <20210907144814.741785-1-imammedo@redhat.com> <20210907144814.741785-9-imammedo@redhat.com> From: Eric Auger Message-ID: <081a9eb2-d409-ca93-fa3b-28a25c7fd2dd@redhat.com> Date: Mon, 20 Sep 2021 18:28:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210907144814.741785-9-imammedo@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eauger@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=eauger@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.475, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mst@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/7/21 4:47 PM, Igor Mammedov wrote: > it replaces error-prone pointer arithmetic for build_header() API, > with 2 calls to start and finish table creation, > which hides offsets magic from API user. > > Signed-off-by: Igor Mammedov Reviewed-by: Eric Auger Eric > --- > v3: > * s/acpi_init_table|acpi_table_composed/acpi_table_begin|acpi_table_end/ > --- > hw/acpi/pci.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/hw/acpi/pci.c b/hw/acpi/pci.c > index 75b1103ec4..20b70dcd81 100644 > --- a/hw/acpi/pci.c > +++ b/hw/acpi/pci.c > @@ -28,19 +28,20 @@ > #include "hw/acpi/pci.h" > #include "hw/pci/pcie_host.h" > > +/* > + * PCI Firmware Specification, Revision 3.0 > + * 4.1.2 MCFG Table Description. > + */ > void build_mcfg(GArray *table_data, BIOSLinker *linker, AcpiMcfgInfo *info, > const char *oem_id, const char *oem_table_id) > { > - int mcfg_start = table_data->len; > + AcpiTable table = { .sig = "MCFG", .rev = 1, > + .oem_id = oem_id, .oem_table_id = oem_table_id }; > + > + acpi_table_begin(&table, table_data); > > - /* > - * PCI Firmware Specification, Revision 3.0 > - * 4.1.2 MCFG Table Description. > - */ > - acpi_data_push(table_data, sizeof(AcpiTableHeader)); > /* Reserved */ > build_append_int_noprefix(table_data, 0, 8); > - > /* > * Memory Mapped Enhanced Configuration Space Base Address Allocation > * Structure > @@ -56,6 +57,5 @@ void build_mcfg(GArray *table_data, BIOSLinker *linker, AcpiMcfgInfo *info, > /* Reserved */ > build_append_int_noprefix(table_data, 0, 4); > > - build_header(linker, table_data, (void *)(table_data->data + mcfg_start), > - "MCFG", table_data->len - mcfg_start, 1, oem_id, oem_table_id); > + acpi_table_end(linker, &table); > } >