From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8AB4FC46467 for ; Wed, 4 Jan 2023 22:52:14 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pDCLx-00026e-TW; Wed, 04 Jan 2023 17:35:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pDCLr-00025X-6H for qemu-devel@nongnu.org; Wed, 04 Jan 2023 17:35:17 -0500 Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pDCLo-00056s-RG for qemu-devel@nongnu.org; Wed, 04 Jan 2023 17:35:14 -0500 Received: by mail-ej1-x631.google.com with SMTP id tz12so86121537ejc.9 for ; Wed, 04 Jan 2023 14:35:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YLCdzstc6Zlv2b8ffgqTCfh63gR16uK1if4Ir20SGyw=; b=oLRRiJkEMDZMLdoSSGmyl774jkUdHj7KXA4FKmO1Qpy018zranziroO62gTaOTqIYR HifPB/dmTa53V1Jw9oU5rA8Q9DzHHSELJ8LaV5mtk3A4ZHubRU8rivE9wwX8SXQsRbiC iEKquh5xpKI77TW/c5wBBrMd6fU9AW6AYGIbPeOlmnNkL9Su7O9/tMt3lrqEjpDTzC+O 6/c7Xv2y5CRCLEsn7zpffACUla9aPjKZNG997as9XJCLlciHTIV7P9QOHq4rZbnm9135 OBb+rrQ0Szxz6n+CZq0pfkTJEhEA/EXA9yL67ikQpePrIk+8Pks8Nau1is+OKOduGfkm YwCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YLCdzstc6Zlv2b8ffgqTCfh63gR16uK1if4Ir20SGyw=; b=dwkx85CXqvhq3QxaPoQYW9FV4+YOKe6m5aXE9Ck3so/9eEGFhrP1QmovMExwAWHKu2 RLidVy6oFh6nKxIzT0qIMYPz1LUmRgX3u8RoVt6I0NV+cpOiidM6/w/53t6Rd6hjg0qp qn6ak97uZPqCT1w5ecmoRyRKEu7T7qDrfPa39O2HSFKKuc93u+iPUbQPdc8b2AW/N6M5 Dx/fnh9s8jlEATr1pO2inJRC7dihvpCZkP7dqMVM4AecV5pHIYpdTawLR0bsScfLaxXZ gqZCOxtRNqZD6WuAkbUszt3cp5EtmFxKLqpt2rkJcB8Rjz1uyYMSN2LxiR9eEojytjUV HI1w== X-Gm-Message-State: AFqh2kqjgWEGdI6jZmwroA24CoXaxnCmLfhDOKpnUuLnirm1z0OMTxE4 eQ4HaSe2+6vFo+OuC9yXOuVpKA== X-Google-Smtp-Source: AMrXdXvO0W1QjvIGDH23S9VCvV1atucqqCQEFMdTyx3rSvLd6e9U15/NdGHKoMN0G5ZsYCzuUOF8Vg== X-Received: by 2002:a17:907:8c82:b0:7c0:f7b2:b19a with SMTP id td2-20020a1709078c8200b007c0f7b2b19amr45770602ejc.27.1672871710088; Wed, 04 Jan 2023 14:35:10 -0800 (PST) Received: from [192.168.1.115] ([185.126.107.38]) by smtp.gmail.com with ESMTPSA id k8-20020a17090632c800b007c0f2c4cdffsm15736530ejk.44.2023.01.04.14.35.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jan 2023 14:35:09 -0800 (PST) Message-ID: <081e95c1-d601-4ed5-678a-e6a828d6ea46@linaro.org> Date: Wed, 4 Jan 2023 23:35:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 1/6] hw/arm/aspeed: Fix smpboot[] on big-endian hosts Content-Language: en-US To: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Peter Maydell Cc: qemu-devel@nongnu.org, Andrew Jeffery , Igor Mitsyanko , Joel Stanley , Havard Skinnemoen , "Edgar E. Iglesias" , Alistair Francis , qemu-arm@nongnu.org, Tyrone Ting References: <20221222215549.86872-1-philmd@linaro.org> <20221222215549.86872-2-philmd@linaro.org> <8fa1d7b7-babc-eca8-bbd9-4707ada2f49f@kaod.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: <8fa1d7b7-babc-eca8-bbd9-4707ada2f49f@kaod.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::631; envelope-from=philmd@linaro.org; helo=mail-ej1-x631.google.com X-Spam_score_int: -37 X-Spam_score: -3.8 X-Spam_bar: --- X-Spam_report: (-3.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.708, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hi Cédric, On 4/1/23 09:43, Cédric Le Goater wrote: > On 1/3/23 18:33, Peter Maydell wrote: >> Can we use the write_bootloader() function, which handles the >> endianness question correctly and is how other boards do the >> "put a little lump of code into the guest" job ? > > Yes. See below. > > May be we could change write_bootloader a little to handle an empty > fixupcontext. > > Thanks, > > C. > > From 671d43faa7e14b896855403feb0afd777350cb0a Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= > Date: Wed, 4 Jan 2023 09:30:28 +0100 > Subject: [PATCH] hw/arm/boot: Export write_bootloader for Aspeed machines > MIME-Version: 1.0 > Content-Type: text/plain; charset=UTF-8 > Content-Transfer-Encoding: 8bit > > AST2600 Aspeed machines have an home made boot loader for secondaries. > Instead, use the internal ARM boot loader. > > Signed-off-by: Cédric Le Goater > --- >  include/hw/arm/boot.h | 24 ++++++++++++++++++++++++ >  hw/arm/aspeed.c       | 42 ++++++++++++++++++++++-------------------- >  hw/arm/boot.c         | 34 +++++++--------------------------- >  3 files changed, 53 insertions(+), 47 deletions(-) [...] I'm getting: Applying: hw/arm/boot: Export write_bootloader for Aspeed machines error: patch failed: include/hw/arm/boot.h:183 error: include/hw/arm/boot.h: patch does not apply error: patch failed: hw/arm/aspeed.c:201 error: hw/arm/aspeed.c: patch does not apply error: patch failed: hw/arm/boot.c:59 error: hw/arm/boot.c: patch does not apply Patch failed at 0001 hw/arm/boot: Export write_bootloader for Aspeed machines hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". What is your base commit? Can you post a normal patch? Thanks, Phil.