From: Max Reitz <mreitz@redhat.com>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 1/2] block: Use bdrv_unref_child() for all children in bdrv_close()
Date: Thu, 23 May 2019 17:57:49 +0200 [thread overview]
Message-ID: <0820158d-ad7b-d091-1e93-dbaf3a672296@redhat.com> (raw)
In-Reply-To: <w51ftp51992.fsf@maestria.local.igalia.com>
[-- Attachment #1: Type: text/plain, Size: 606 bytes --]
On 23.05.19 17:27, Alberto Garcia wrote:
> On Mon 13 May 2019 03:46:17 PM CEST, Alberto Garcia wrote:
>> Now bdrv_close() unrefs all children (before this patch it was only
>> bs->file and bs->backing). As a result, none of the callers of
>> brvd_attach_child() should remove their reference to child_bs (because
>> this function effectively steals that reference). This patch updates a
>> couple of tests that where doing their own bdrv_unref().
>
> s/that where doing/that were doing/
>
> Max, if it's not too late can you fix that in your block branch?
Sure. It’s fixed now.
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-05-23 16:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-13 13:46 [Qemu-devel] [PATCH v3 0/2] block: Use bdrv_unref_child() for all children in bdrv_close() Alberto Garcia
2019-05-13 13:46 ` [Qemu-devel] [PATCH v3 1/2] " Alberto Garcia
2019-05-23 15:27 ` Alberto Garcia
2019-05-23 15:57 ` Max Reitz [this message]
2019-05-13 13:46 ` [Qemu-devel] [PATCH v3 2/2] block: Make bdrv_root_attach_child() unref child_bs on failure Alberto Garcia
2019-05-13 14:31 ` Max Reitz
2019-05-13 15:52 ` Alberto Garcia
2019-05-13 15:54 ` Max Reitz
2019-05-13 14:32 ` [Qemu-devel] [PATCH v3 0/2] block: Use bdrv_unref_child() for all children in bdrv_close() Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0820158d-ad7b-d091-1e93-dbaf3a672296@redhat.com \
--to=mreitz@redhat.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).