From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90D47C38A2A for ; Thu, 7 May 2020 16:11:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 589402083B for ; Thu, 7 May 2020 16:11:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gVXsVdJ9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 589402083B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47050 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jWj72-0007Un-DQ for qemu-devel@archiver.kernel.org; Thu, 07 May 2020 12:11:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38192) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jWj67-0006Rp-7f for qemu-devel@nongnu.org; Thu, 07 May 2020 12:10:07 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:57126 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jWj66-0000T2-KL for qemu-devel@nongnu.org; Thu, 07 May 2020 12:10:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588867806; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hwjq21lcCrQqwZ5+slNoct19Z90wGFnf91z6iYgKdZA=; b=gVXsVdJ9d8XdQ+IqqSJ0BqYJjDdUt4m9Nlg7H355nX2r0UnjJtLRX65alLLOCDlzdRGUej EskKLzGm/s7o/TuC2horTRXuN/UMuwkgSgT5cTFhtxH0V1Z7JrV1KIaCXLSfTbk7WBwsJC Or9lLkLRESN1bPc67HhD6tC9gkM+Z9Y= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-487-GAyhwXHKM9GMXZ-Gkl5pug-1; Thu, 07 May 2020 12:09:48 -0400 X-MC-Unique: GAyhwXHKM9GMXZ-Gkl5pug-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 41953800687; Thu, 7 May 2020 16:09:47 +0000 (UTC) Received: from [10.3.114.73] (ovpn-114-73.phx2.redhat.com [10.3.114.73]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9CD1660FB9; Thu, 7 May 2020 16:09:45 +0000 (UTC) Subject: Re: [PATCH v5 01/14] qcrypto/core: add generic infrastructure for crypto options amendment To: Maxim Levitsky , qemu-devel@nongnu.org References: <20200507125414.2151-1-mlevitsk@redhat.com> <20200507125414.2151-2-mlevitsk@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: <08257b8a-ed70-1a6d-ffb9-20441b5af91f@redhat.com> Date: Thu, 7 May 2020 11:09:43 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200507125414.2151-2-mlevitsk@redhat.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=207.211.31.81; envelope-from=eblake@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/07 00:55:34 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , qemu-block@nongnu.org, Markus Armbruster , Max Reitz , John Snow Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/7/20 7:54 AM, Maxim Levitsky wrote: > This will be used first to implement luks keyslot management. >=20 > block_crypto_amend_opts_init will be used to convert > qemu-img cmdline to QCryptoBlockAmendOptions >=20 > Signed-off-by: Maxim Levitsky > Reviewed-by: Daniel P. Berrang=C3=A9 > --- > +++ b/qapi/crypto.json > @@ -309,3 +309,19 @@ > 'base': 'QCryptoBlockInfoBase', > 'discriminator': 'format', > 'data': { 'luks': 'QCryptoBlockInfoLUKS' } } > + > + > + > +## > +# @QCryptoBlockAmendOptions: > +# > +# The options that are available for all encryption formats > +# when amending encryption settings > +# > +# Since: 5.0 Looks like our mail crossed, my v4 review landed after you sent v5.=20 We'll still have to scrub this series for s/5.0/5.1/ > +## > +{ 'union': 'QCryptoBlockAmendOptions', > + 'base': 'QCryptoBlockOptionsBase', > + 'discriminator': 'format', > + 'data': { > + } } >=20 --=20 Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org