From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Bug 1753437 <1753437@bugs.launchpad.net>,
qemu-devel@nongnu.org, Cornelia Huck <cohuck@redhat.com>,
"Collin L. Walling" <walling@linux.vnet.ibm.com>,
qemu-s390x <qemu-s390x@nongnu.org>
Subject: Re: [Qemu-devel] [Bug 1753437] [NEW] qemu/pc-bios/s390-ccw/libc.c:82: bad test ?
Date: Mon, 5 Mar 2018 12:22:50 +0100 [thread overview]
Message-ID: <083d2e7c-5ada-88c9-bf50-0c68e7c19136@de.ibm.com> (raw)
In-Reply-To: <152024589806.7327.9844777027357521578.malonedeb@gac.canonical.com>
Adding qemu-s390x.
On 03/05/2018 11:31 AM, dcb wrote:
> Public bug reported:
>
> qemu/pc-bios/s390-ccw/libc.c:82]: (style) Unsigned variable 'num_idx'
> can't be negative so it is unnecessary to test it.
>
> Source code is
>
>
> while (num_idx >= 0) {
>
> but
>
> size_t num_idx = 1; /* account for NUL */
>
> So there is no escape from the while loop.
>
> ** Affects: qemu
> Importance: Undecided
> Status: New
>
next prev parent reply other threads:[~2018-03-05 11:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 10:31 [Qemu-devel] [Bug 1753437] [NEW] qemu/pc-bios/s390-ccw/libc.c:82: bad test ? dcb
2018-03-05 11:22 ` Christian Borntraeger [this message]
2018-03-05 14:53 ` Thomas Huth
2018-03-05 15:30 ` [Qemu-devel] [qemu-s390x] " Collin L. Walling
2018-03-12 6:42 ` [Qemu-devel] [Bug 1753437] " Thomas Huth
2018-04-13 15:47 ` [Qemu-devel] [Bug 1753437] Re: pc-bios/s390-ccw/libc: size_t should be unsigned Thomas Huth
2018-05-04 14:00 ` Thomas Huth
2018-08-15 7:28 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=083d2e7c-5ada-88c9-bf50-0c68e7c19136@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=1753437@bugs.launchpad.net \
--cc=cohuck@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=walling@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).