From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
qemu-arm@nongnu.org, alex.bennee@linaro.org,
"Peter Maydell" <peter.maydell@linaro.org>,
kvm@vger.kernel.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH 05/13] target/arm/cpu: move KVM_HAVE_MCE_INJECTION to kvm-all.c file directly
Date: Wed, 19 Mar 2025 16:06:19 -0700 [thread overview]
Message-ID: <0845395e-f306-4fb3-bf4c-9723be4c969d@linaro.org> (raw)
In-Reply-To: <f1ce73a6-717b-4230-95cd-45505fecf039@linaro.org>
On 3/18/25 15:19, Richard Henderson wrote:
> On 3/17/25 21:51, Pierrick Bouvier wrote:
>> diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
>> index f89568bfa39..28de3990699 100644
>> --- a/accel/kvm/kvm-all.c
>> +++ b/accel/kvm/kvm-all.c
>> @@ -13,6 +13,10 @@
>> *
>> */
>>
>> +#ifdef TARGET_AARCH64
>> +#define KVM_HAVE_MCE_INJECTION 1
>> +#endif
>> +
>> #include "qemu/osdep.h"
>> #include <sys/ioctl.h>
>> #include <poll.h>
>
> I think this define should go after all #includes, emphasizing that it only affects this file.
>
> I think the #ifdef should use __aarch64__. KVM is explicitly only for the host, so
> TARGET_AARCH64 really means the host is also AArch64.
>
> I think you should go ahead and adjust x86_64 either with the same patch or immediately
> afterward. There are only two users after all.
>
I'll adjust this for x86_64 in the same patch.
>
> r~
next prev parent reply other threads:[~2025-03-19 23:07 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 4:51 [PATCH 00/13] single-binary: start make hw/arm/ common (boot.c) Pierrick Bouvier
2025-03-18 4:51 ` [PATCH 01/13] exec/cpu-all: restrict BSWAP_NEEDED to target specific code Pierrick Bouvier
2025-03-18 21:41 ` Richard Henderson
2025-03-18 22:35 ` Pierrick Bouvier
2025-03-18 4:51 ` [PATCH 02/13] exec/cpu-all: restrict compile time assert " Pierrick Bouvier
2025-03-18 4:51 ` [PATCH 03/13] exec/target_page: runtime defintion for TARGET_PAGE_BITS_MIN Pierrick Bouvier
2025-03-18 4:51 ` [PATCH 04/13] exec/cpu-all: allow to include specific cpu Pierrick Bouvier
2025-03-18 22:11 ` Richard Henderson
2025-03-18 22:16 ` Pierrick Bouvier
2025-03-18 22:21 ` Richard Henderson
2025-03-18 22:25 ` Pierrick Bouvier
2025-03-18 22:36 ` Richard Henderson
2025-03-18 22:58 ` Pierrick Bouvier
2025-03-18 4:51 ` [PATCH 05/13] target/arm/cpu: move KVM_HAVE_MCE_INJECTION to kvm-all.c file directly Pierrick Bouvier
2025-03-18 22:19 ` Richard Henderson
2025-03-19 23:06 ` Pierrick Bouvier [this message]
2025-03-18 4:51 ` [PATCH 06/13] exec/poison: KVM_HAVE_MCE_INJECTION can now be poisoned Pierrick Bouvier
2025-03-18 22:22 ` Richard Henderson
2025-03-18 4:51 ` [PATCH 07/13] target/arm/cpu: always define kvm related registers Pierrick Bouvier
2025-03-18 18:14 ` Philippe Mathieu-Daudé
2025-03-18 18:23 ` Pierrick Bouvier
2025-03-18 4:51 ` [PATCH 08/13] target/arm/cpu: flags2 is always uint64_t Pierrick Bouvier
2025-03-18 22:40 ` Richard Henderson
2025-03-19 23:17 ` Pierrick Bouvier
2025-03-18 4:51 ` [PATCH 09/13] target/arm/cpu: define ARM_MAX_VQ once for aarch32 and aarch64 Pierrick Bouvier
2025-03-18 18:50 ` Philippe Mathieu-Daudé
2025-03-18 22:02 ` Pierrick Bouvier
2025-03-19 7:03 ` Philippe Mathieu-Daudé
2025-03-19 23:09 ` Pierrick Bouvier
2025-03-18 22:44 ` Richard Henderson
2025-03-18 4:51 ` [PATCH 10/13] target/arm/cpu: define same set of registers " Pierrick Bouvier
2025-03-18 22:45 ` Richard Henderson
2025-03-19 23:25 ` Pierrick Bouvier
2025-03-18 4:51 ` [PATCH 11/13] target/arm/cpu: remove inline stubs for aarch32 emulation Pierrick Bouvier
2025-03-18 17:42 ` Philippe Mathieu-Daudé
2025-03-18 17:50 ` Peter Maydell
2025-03-18 17:52 ` Pierrick Bouvier
2025-03-18 18:06 ` Peter Maydell
2025-03-18 18:13 ` Pierrick Bouvier
2025-03-19 23:35 ` Pierrick Bouvier
2025-03-18 18:44 ` Philippe Mathieu-Daudé
2025-03-18 17:50 ` Pierrick Bouvier
2025-03-18 4:51 ` [PATCH 12/13] meson: add common hw files Pierrick Bouvier
2025-03-18 4:51 ` [PATCH 13/13] hw/arm/boot: make compilation unit hw common Pierrick Bouvier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0845395e-f306-4fb3-bf4c-9723be4c969d@linaro.org \
--to=pierrick.bouvier@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).