From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE0F2C38A2D for ; Tue, 25 Oct 2022 14:34:28 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1onKyZ-0002AD-T6; Tue, 25 Oct 2022 10:32:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1onKyY-00029i-JQ for qemu-devel@nongnu.org; Tue, 25 Oct 2022 10:32:18 -0400 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1onKyW-00054N-Nk for qemu-devel@nongnu.org; Tue, 25 Oct 2022 10:32:18 -0400 Received: by mail-ed1-x52c.google.com with SMTP id y69so17511487ede.5 for ; Tue, 25 Oct 2022 07:32:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=a62MrLf/oj733bG19pKm7Lu16G+ICPxvMyKnqoPvQw4=; b=odT4rOMX2vuPOw9pJEcWHtExO7/pUijKK72M7tAEvOyUrsNf3ARx0qPPToyrI9cwYN KyqNKyBlq/uCGcUsNNRXS/6miy+PiO6q5Mdf0Wer92/3j96oqaWI+u2nrBQDQOG8KRv8 WBb7U0oV/l+Envq0GWPEfU+lkyswpJxozL833o9a1+q8aaT2leeSbSNHGec+CiER0YXO /vOYFe5EgpTK6OcLbLmH1nXiCRGEAuws/LoKGNH+w3/EFSQPyRykV2uX8A5D0QhgGGgm P8gL/HZ3+rDH+vcn+SRV/iAr7oaAwefT9oTTaaNu47VLIZemR4Lmj39ujhZWeiIIhUth PRkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=a62MrLf/oj733bG19pKm7Lu16G+ICPxvMyKnqoPvQw4=; b=7G9GhW8YuhIyWYKllnpcsz4Y9CVKvCmMPWyxEBnLcAxhII9haCm0yoGdf62Bg/VmuM phStRArMgKVHofOn7/uKHGWcZIs2tRM7eOuT8VQJBf7ldBrItYKhuKbp4trtl1F5KHsP qMHs6eYE6QyG5DEEQbAOUqdKemIEM1Ja+Tr8+Lu3ZQkPXY6TJSGdwmqCrtXDhpZ/c7wK YRZ4vXxBmfjpEeGuYJ1JpbwDY3TxGgIY2WTY8qahiN2SD/S+pLaK9BuU6G+EdBCxrMGT RQJvuy8sxrwN1ielFit/GPHkDhPJ7I5s7zG8/WuMzMXfKwgrcbaSjMdCOqMIUeqbb7HQ FSJQ== X-Gm-Message-State: ACrzQf1GN99ZeTcVwm7IYB1fu2NGONNxClW2bxvThsVMtt/46NtHgeSn l/mmFSjeugG8GlZcrydjSE5VE2f/FbgbM1ey/qk= X-Google-Smtp-Source: AMsMyM5ZwozhjNi01XT80Cc84TOatK7wZJpeHD4+DNv7biZ2FJ7+DhV4m3CJZzvz9dln18yCP9vSMA== X-Received: by 2002:a05:6402:3217:b0:461:d6d7:7f19 with SMTP id g23-20020a056402321700b00461d6d77f19mr8672688eda.109.1666708334115; Tue, 25 Oct 2022 07:32:14 -0700 (PDT) Received: from [192.168.1.9] ([202.21.109.40]) by smtp.gmail.com with ESMTPSA id o20-20020a170906769400b007acbac07f07sm739397ejm.51.2022.10.25.07.32.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Oct 2022 07:32:13 -0700 (PDT) Message-ID: <0848444f-1940-329d-9e3d-0b6b86cf36c6@gmail.com> Date: Tue, 25 Oct 2022 22:32:11 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v3 2/4] hw/audio: fix tab indentation Content-Language: en-US From: Amarjargal Gundjalam To: =?UTF-8?Q?Volker_R=c3=bcmelin?= Cc: Gerd Hoffmann , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Thomas Huth , qemu-devel@nongnu.org References: <5072d17c33b7bdb068f45308961259889ce1fd8a.1666371096.git.amarjargal16@gmail.com> <2448bc23-3849-a25b-8e77-f487ae7efb46@t-online.de> <407d964d-7a00-4e94-a0d7-054eb6f881cf@gmail.com> In-Reply-To: <407d964d-7a00-4e94-a0d7-054eb6f881cf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::52c; envelope-from=amarjargal16@gmail.com; helo=mail-ed1-x52c.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Qemu-devel" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 24/10/22 23:42, Amarjargal Gundjalam wrote: > > On 23/10/22 15:53, Volker Rümelin wrote: >> Am 21.10.22 um 18:59 schrieb Amarjargal Gundjalam: >> >>> The TABs should be replaced with spaces, to make sure that we have a >>> consistent coding style with an indentation of 4 spaces everywhere. >>> >>> Resolves:https://gitlab.com/qemu-project/qemu/-/issues/370 >>> Reviewed-by: Daniel P. Berrangé >>> >>> Signed-off-by: Amarjargal Gundjalam >>> --- >>>   hw/audio/fmopl.c          | 1664 >>> ++++++++++++++++++------------------- >>>   hw/audio/fmopl.h          |  138 +-- >>>   hw/audio/intel-hda-defs.h | 1008 +++++++++++----------- >>>   hw/audio/wm8750.c         |  270 +++--- >>>   4 files changed, 1540 insertions(+), 1540 deletions(-) >> >> Hi Amarjargal, >> >> I had a look at hw/audio/fmopl.c and I think the result doesn't look >> right. A few comments are no longer correctly aligned. I guess you >> just replaced all TABs with four spaces. But this is not how TABs work. >> >> For reference: I used the vim command >> >> :%s/^I/    /g >> >> and the result is identical to your file. The commands >> >> :se ts=4 expandtab >> :retab >> >> would have been a much better starting point for the last few manual >> changes. >> >> Here is another example. For the file hw/audio/wm8750.c I would have >> started with the following vim commands >> >> :se ts=8 expandtab >> :retab >> >> With best regards, >> Volker > > Hi Volker, > > Thank you for your review! > > Yes, I did indeed replaced all the tabs with spaces. I'll fix all of > them and update. > > Best Regards, > > Amarjargal > > Hello again, I redid the whole thing with vim retab and sent a new version of the patches. I hope they're alright this time. Thank you, Amarjargal