qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Pavel Dovgalyuk <pavel.dovgalyuk@ispras.ru>, qemu-devel@nongnu.org
Cc: alex.bennee@linaro.org
Subject: Re: [PATCH v3] replay: notify CPU on event
Date: Thu, 1 Apr 2021 10:49:50 +0200	[thread overview]
Message-ID: <085ea81c-6d08-11b1-d496-568320f53de7@redhat.com> (raw)
In-Reply-To: <161726519158.1476949.7614181684462079836.stgit@pasha-ThinkPad-X280>

On 01/04/21 10:19, Pavel Dovgalyuk wrote:
> This patch enables vCPU notification to wake it up
> when new async event comes in replay mode.
> 
> The motivation of this patch is the following.
> Consider recorded block async event. It is saved into the log
> with one of the checkpoints. This checkpoint may be passed in
> vCPU loop. In replay mode when this async event is read from
> the log, and block thread task is not finished yet, vCPU thread
> goes to sleep. That is why this patch adds waking up the vCPU
> to process this finished event.
> 
> Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
> ---
>   replay/replay-events.c |    2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/replay/replay-events.c b/replay/replay-events.c
> index a1c6bb934e..15983dd250 100644
> --- a/replay/replay-events.c
> +++ b/replay/replay-events.c
> @@ -15,6 +15,7 @@
>   #include "replay-internal.h"
>   #include "block/aio.h"
>   #include "ui/input.h"
> +#include "hw/core/cpu.h"
>   
>   typedef struct Event {
>       ReplayAsyncEventKind event_kind;
> @@ -126,6 +127,7 @@ void replay_add_event(ReplayAsyncEventKind event_kind,
>   
>       g_assert(replay_mutex_locked());
>       QTAILQ_INSERT_TAIL(&events_list, event, events);
> +    qemu_cpu_kick(first_cpu);
>   }
>   
>   void replay_bh_schedule_event(QEMUBH *bh)
> 

Queued, thanks.

Paolo



      reply	other threads:[~2021-04-01  8:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-01  8:19 [PATCH v3] replay: notify CPU on event Pavel Dovgalyuk
2021-04-01  8:49 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=085ea81c-6d08-11b1-d496-568320f53de7@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=pavel.dovgalyuk@ispras.ru \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).