From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58089)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mark.burton@greensocs.com>) id 1Z2K6a-00013J-BO
	for qemu-devel@nongnu.org; Tue, 09 Jun 2015 10:02:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mark.burton@greensocs.com>) id 1Z2K6V-00035H-QD
	for qemu-devel@nongnu.org; Tue, 09 Jun 2015 10:02:15 -0400
Received: from greensocs.com ([193.104.36.180]:41160)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mark.burton@greensocs.com>) id 1Z2K6V-00034v-DD
	for qemu-devel@nongnu.org; Tue, 09 Jun 2015 10:02:11 -0400
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\))
From: Mark Burton <mark.burton@greensocs.com>
In-Reply-To: <87oakp6kzl.fsf@linaro.org>
Date: Tue, 9 Jun 2015 16:02:06 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <0860533C-AC27-4A7B-ABDA-9333A2FB7B7F@greensocs.com>
References: <1433514678-4464-1-git-send-email-fred.konrad@greensocs.com>
	<87oakp6kzl.fsf@linaro.org>
Subject: Re: [Qemu-devel] [RFC PATCH] Use atomic cmpxchg to atomically check
	the exclusive value in a STREX
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?utf-8?Q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>
Cc: mttcg@listserver.greensocs.com, Peter Maydell <peter.maydell@linaro.org>, Alexander Graf <agraf@suse.de>, QEMU Developers <qemu-devel@nongnu.org>, Guillaume Delbergue <guillaume.delbergue@greensocs.com>, Paolo Bonzini <pbonzini@redhat.com>, =?utf-8?Q?KONRAD_Fr=C3=A9d=C3=A9ric?= <fred.konrad@greensocs.com>


> On 9 Jun 2015, at 15:59, Alex Benn=C3=A9e <alex.bennee@linaro.org> =
wrote:
>=20
>=20
> fred.konrad@greensocs.com writes:
>=20
>> From: KONRAD Frederic <fred.konrad@greensocs.com>
>>=20

<snip>

>> +DEF_HELPER_4(atomic_cmpxchg64, i32, env, i32, i64, i32)
>> +DEF_HELPER_2(atomic_check, i32, env, i32)
>> +DEF_HELPER_1(atomic_release, void, env)
>=20
> Apologies for being split over several mails, I didn't notice before

No problem - personally prefer to keep the threads separate.

> that atomic_check/release don't seem to be called at all in this =
patch.
> Is there later work that uses it?

I suspect that this is just a case of not cleaning up- I think we used =
check and release, and then ditched them=E2=80=A6 I=E2=80=99ll check =
(and release :-) )

Cheers
Mark.