Re: [Qemu-devel] [PATCH] tests/vm: remove unused --target-list option

[John Snow <jsnow@redhat.com>]

On 9/17/19 3:30 PM, Alex Bennée wrote:
> 
> John Snow <jsnow@redhat.com> writes:
> 
>> On 9/17/19 2:58 PM, Alex Bennée wrote:
>>>
>>> John Snow <jsnow@redhat.com> writes:
>>>
>>>> It's not used; so remove the distraction.
>>>
>>> It's a developer feature so you can run specific builds against the VM
>>> images. I certainly have used it, unless you are saying it's broken now?
>>>
>>
>> What consumes it? I can't find where it *does* something:
> 
> It's past as the rest:
> 
>                 -- \ <- all args after this
> 		$(if $(TARGET_LIST),--target-list=$(TARGET_LIST)) \
> 		$(if $(EXTRA_CONFIGURE_OPTS),$(EXTRA_CONFIGURE_OPTS)), \
> 
> Become argv in:
> 
>         args, argv = parse_args(vmcls)
>         ...
>                     cmd = [vm.BUILD_SCRIPT.format(
>                    configure_opts = " ".join(argv),
>                    jobs=int(args.jobs),
>                    target=args.build_target,
>                    verbose = "V=1" if args.verbose else "")]
> 

augh, optparse ... okay, I goofed. I didn't realize they come back
unparsed. So they become configure options specifically, OK, got it.

Disregard, sorry!

NACK

--js