* [Qemu-devel] [PATCH] tests/vm: remove unused --target-list option
@ 2019-09-17 18:49 John Snow
2019-09-17 18:58 ` Alex Bennée
0 siblings, 1 reply; 5+ messages in thread
From: John Snow @ 2019-09-17 18:49 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Alex Bennée, John Snow,
Philippe Mathieu-Daudé
It's not used; so remove the distraction.
Signed-off-by: John Snow <jsnow@redhat.com>
---
tests/vm/Makefile.include | 2 --
1 file changed, 2 deletions(-)
diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include
index fea348e845..61758101fa 100644
--- a/tests/vm/Makefile.include
+++ b/tests/vm/Makefile.include
@@ -28,7 +28,6 @@ vm-help vm-test:
@echo
@echo "Special variables:"
@echo " BUILD_TARGET=foo - Override the build target"
- @echo " TARGET_LIST=a,b,c - Override target list in builds"
@echo ' EXTRA_CONFIGURE_OPTS="..."'
@echo " J=[0..9]* - Override the -jN parameter for make commands"
@echo " DEBUG=1 - Enable verbose output on host and interactive debugging"
@@ -65,7 +64,6 @@ vm-build-%: $(IMAGES_DIR)/%.img
$(if $(BUILD_TARGET),--build-target $(BUILD_TARGET)) \
--snapshot \
--build-qemu $(SRC_PATH) -- \
- $(if $(TARGET_LIST),--target-list=$(TARGET_LIST)) \
$(if $(EXTRA_CONFIGURE_OPTS),$(EXTRA_CONFIGURE_OPTS)), \
" VM-BUILD $*")
--
2.21.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] tests/vm: remove unused --target-list option
2019-09-17 18:49 [Qemu-devel] [PATCH] tests/vm: remove unused --target-list option John Snow
@ 2019-09-17 18:58 ` Alex Bennée
2019-09-17 19:00 ` John Snow
0 siblings, 1 reply; 5+ messages in thread
From: Alex Bennée @ 2019-09-17 18:58 UTC (permalink / raw)
To: John Snow; +Cc: Fam Zheng, Philippe Mathieu-Daudé, qemu-devel
John Snow <jsnow@redhat.com> writes:
> It's not used; so remove the distraction.
It's a developer feature so you can run specific builds against the VM
images. I certainly have used it, unless you are saying it's broken now?
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> tests/vm/Makefile.include | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include
> index fea348e845..61758101fa 100644
> --- a/tests/vm/Makefile.include
> +++ b/tests/vm/Makefile.include
> @@ -28,7 +28,6 @@ vm-help vm-test:
> @echo
> @echo "Special variables:"
> @echo " BUILD_TARGET=foo - Override the build target"
> - @echo " TARGET_LIST=a,b,c - Override target list in builds"
> @echo ' EXTRA_CONFIGURE_OPTS="..."'
> @echo " J=[0..9]* - Override the -jN parameter for make commands"
> @echo " DEBUG=1 - Enable verbose output on host and interactive debugging"
> @@ -65,7 +64,6 @@ vm-build-%: $(IMAGES_DIR)/%.img
> $(if $(BUILD_TARGET),--build-target $(BUILD_TARGET)) \
> --snapshot \
> --build-qemu $(SRC_PATH) -- \
> - $(if $(TARGET_LIST),--target-list=$(TARGET_LIST)) \
> $(if $(EXTRA_CONFIGURE_OPTS),$(EXTRA_CONFIGURE_OPTS)), \
> " VM-BUILD $*")
--
Alex Bennée
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] tests/vm: remove unused --target-list option
2019-09-17 18:58 ` Alex Bennée
@ 2019-09-17 19:00 ` John Snow
2019-09-17 19:30 ` Alex Bennée
0 siblings, 1 reply; 5+ messages in thread
From: John Snow @ 2019-09-17 19:00 UTC (permalink / raw)
To: Alex Bennée; +Cc: Fam Zheng, Philippe Mathieu-Daudé, qemu-devel
On 9/17/19 2:58 PM, Alex Bennée wrote:
>
> John Snow <jsnow@redhat.com> writes:
>
>> It's not used; so remove the distraction.
>
> It's a developer feature so you can run specific builds against the VM
> images. I certainly have used it, unless you are saying it's broken now?
>
What consumes it? I can't find where it *does* something:
jhuston@probe ~/s/q/t/vm (docker-partial-fixup)> git grep TARGET_LIST
Makefile.include: @echo " TARGET_LIST=a,b,c -
Override target list in builds"
Makefile.include: $(if
$(TARGET_LIST),--target-list=$(TARGET_LIST)) \
jhuston@probe ~/s/q/t/vm (docker-partial-fixup)> git grep target-list
Makefile.include: $(if
$(TARGET_LIST),--target-list=$(TARGET_LIST)) \
jhuston@probe ~/s/q/t/vm (docker-partial-fixup)> git grep target_list
jhuston@probe ~/s/q/t/vm (docker-partial-fixup) [1]>
the VM script doesn't seem to pick it up or apply defaults, so I don't
know where this was supposed to be routed to.
>>
>> Signed-off-by: John Snow <jsnow@redhat.com>
>> ---
>> tests/vm/Makefile.include | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include
>> index fea348e845..61758101fa 100644
>> --- a/tests/vm/Makefile.include
>> +++ b/tests/vm/Makefile.include
>> @@ -28,7 +28,6 @@ vm-help vm-test:
>> @echo
>> @echo "Special variables:"
>> @echo " BUILD_TARGET=foo - Override the build target"
>> - @echo " TARGET_LIST=a,b,c - Override target list in builds"
>> @echo ' EXTRA_CONFIGURE_OPTS="..."'
>> @echo " J=[0..9]* - Override the -jN parameter for make commands"
>> @echo " DEBUG=1 - Enable verbose output on host and interactive debugging"
>> @@ -65,7 +64,6 @@ vm-build-%: $(IMAGES_DIR)/%.img
>> $(if $(BUILD_TARGET),--build-target $(BUILD_TARGET)) \
>> --snapshot \
>> --build-qemu $(SRC_PATH) -- \
>> - $(if $(TARGET_LIST),--target-list=$(TARGET_LIST)) \
>> $(if $(EXTRA_CONFIGURE_OPTS),$(EXTRA_CONFIGURE_OPTS)), \
>> " VM-BUILD $*")
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] tests/vm: remove unused --target-list option
2019-09-17 19:00 ` John Snow
@ 2019-09-17 19:30 ` Alex Bennée
2019-09-17 19:52 ` John Snow
0 siblings, 1 reply; 5+ messages in thread
From: Alex Bennée @ 2019-09-17 19:30 UTC (permalink / raw)
To: John Snow; +Cc: Fam Zheng, Philippe Mathieu-Daudé, qemu-devel
John Snow <jsnow@redhat.com> writes:
> On 9/17/19 2:58 PM, Alex Bennée wrote:
>>
>> John Snow <jsnow@redhat.com> writes:
>>
>>> It's not used; so remove the distraction.
>>
>> It's a developer feature so you can run specific builds against the VM
>> images. I certainly have used it, unless you are saying it's broken now?
>>
>
> What consumes it? I can't find where it *does* something:
It's past as the rest:
-- \ <- all args after this
$(if $(TARGET_LIST),--target-list=$(TARGET_LIST)) \
$(if $(EXTRA_CONFIGURE_OPTS),$(EXTRA_CONFIGURE_OPTS)), \
Become argv in:
args, argv = parse_args(vmcls)
...
cmd = [vm.BUILD_SCRIPT.format(
configure_opts = " ".join(argv),
jobs=int(args.jobs),
target=args.build_target,
verbose = "V=1" if args.verbose else "")]
>
> jhuston@probe ~/s/q/t/vm (docker-partial-fixup)> git grep TARGET_LIST
> Makefile.include: @echo " TARGET_LIST=a,b,c -
> Override target list in builds"
> Makefile.include: $(if
> $(TARGET_LIST),--target-list=$(TARGET_LIST)) \
> jhuston@probe ~/s/q/t/vm (docker-partial-fixup)> git grep target-list
> Makefile.include: $(if
> $(TARGET_LIST),--target-list=$(TARGET_LIST)) \
> jhuston@probe ~/s/q/t/vm (docker-partial-fixup)> git grep target_list
> jhuston@probe ~/s/q/t/vm (docker-partial-fixup) [1]>
>
>
> the VM script doesn't seem to pick it up or apply defaults, so I don't
> know where this was supposed to be routed to.
>
>
>>>
>>> Signed-off-by: John Snow <jsnow@redhat.com>
>>> ---
>>> tests/vm/Makefile.include | 2 --
>>> 1 file changed, 2 deletions(-)
>>>
>>> diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include
>>> index fea348e845..61758101fa 100644
>>> --- a/tests/vm/Makefile.include
>>> +++ b/tests/vm/Makefile.include
>>> @@ -28,7 +28,6 @@ vm-help vm-test:
>>> @echo
>>> @echo "Special variables:"
>>> @echo " BUILD_TARGET=foo - Override the build target"
>>> - @echo " TARGET_LIST=a,b,c - Override target list in builds"
>>> @echo ' EXTRA_CONFIGURE_OPTS="..."'
>>> @echo " J=[0..9]* - Override the -jN parameter for make commands"
>>> @echo " DEBUG=1 - Enable verbose output on host and interactive debugging"
>>> @@ -65,7 +64,6 @@ vm-build-%: $(IMAGES_DIR)/%.img
>>> $(if $(BUILD_TARGET),--build-target $(BUILD_TARGET)) \
>>> --snapshot \
>>> --build-qemu $(SRC_PATH) -- \
>>> - $(if $(TARGET_LIST),--target-list=$(TARGET_LIST)) \
>>> $(if $(EXTRA_CONFIGURE_OPTS),$(EXTRA_CONFIGURE_OPTS)), \
>>> " VM-BUILD $*")
>>
>>
--
Alex Bennée
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] tests/vm: remove unused --target-list option
2019-09-17 19:30 ` Alex Bennée
@ 2019-09-17 19:52 ` John Snow
0 siblings, 0 replies; 5+ messages in thread
From: John Snow @ 2019-09-17 19:52 UTC (permalink / raw)
To: Alex Bennée; +Cc: Fam Zheng, Philippe Mathieu-Daudé, qemu-devel
On 9/17/19 3:30 PM, Alex Bennée wrote:
>
> John Snow <jsnow@redhat.com> writes:
>
>> On 9/17/19 2:58 PM, Alex Bennée wrote:
>>>
>>> John Snow <jsnow@redhat.com> writes:
>>>
>>>> It's not used; so remove the distraction.
>>>
>>> It's a developer feature so you can run specific builds against the VM
>>> images. I certainly have used it, unless you are saying it's broken now?
>>>
>>
>> What consumes it? I can't find where it *does* something:
>
> It's past as the rest:
>
> -- \ <- all args after this
> $(if $(TARGET_LIST),--target-list=$(TARGET_LIST)) \
> $(if $(EXTRA_CONFIGURE_OPTS),$(EXTRA_CONFIGURE_OPTS)), \
>
> Become argv in:
>
> args, argv = parse_args(vmcls)
> ...
> cmd = [vm.BUILD_SCRIPT.format(
> configure_opts = " ".join(argv),
> jobs=int(args.jobs),
> target=args.build_target,
> verbose = "V=1" if args.verbose else "")]
>
augh, optparse ... okay, I goofed. I didn't realize they come back
unparsed. So they become configure options specifically, OK, got it.
Disregard, sorry!
NACK
--js
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-09-17 19:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-17 18:49 [Qemu-devel] [PATCH] tests/vm: remove unused --target-list option John Snow
2019-09-17 18:58 ` Alex Bennée
2019-09-17 19:00 ` John Snow
2019-09-17 19:30 ` Alex Bennée
2019-09-17 19:52 ` John Snow
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).