From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D4F3C433E0 for ; Thu, 14 Jan 2021 06:28:19 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 34F29238E7 for ; Thu, 14 Jan 2021 06:28:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 34F29238E7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58820 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kzw7F-000285-3e for qemu-devel@archiver.kernel.org; Thu, 14 Jan 2021 01:28:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44552) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kzw5v-0001K7-Mm for qemu-devel@nongnu.org; Thu, 14 Jan 2021 01:26:58 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:59700) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kzw5s-0001dZ-1c for qemu-devel@nongnu.org; Thu, 14 Jan 2021 01:26:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610605610; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=psmIzOD9lzkpnYIQW4/BOG8l/eg6MD3R/B2vPGlNUx0=; b=Zs1Z8Ruj0r7uMrdlIcBnGpauyN2t2hImhSzJVTMBRY0YpQ0AMWSxjNo4oahTzh/IR4CUPq f8WTHBudtMBP/NlprbgAzb1ug5YRllOSWRUNTAw6yjTp2ukdrCoF9lkUFmXHBq39G+jsOS 0n27FeT995HyPObRiTZlSp9fh7GsA4A= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-295-IZy6Z5g1Np6-SkSgo9QUJg-1; Thu, 14 Jan 2021 01:26:46 -0500 X-MC-Unique: IZy6Z5g1Np6-SkSgo9QUJg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C97468066E1; Thu, 14 Jan 2021 06:26:45 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-108.ams2.redhat.com [10.36.112.108]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9E13A10016FB; Thu, 14 Jan 2021 06:26:44 +0000 (UTC) Subject: Re: [PATCH v2] osdep.h: Remove include To: Michael Forney , qemu-devel@nongnu.org References: <20201027003848.10920-1-mforney@mforney.org> <20210113215600.16100-1-mforney@mforney.org> From: Thomas Huth Message-ID: <08a896b4-8a5b-bf91-7c7c-7d5232e8fcd9@redhat.com> Date: Thu, 14 Jan 2021 07:26:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.3 MIME-Version: 1.0 In-Reply-To: <20210113215600.16100-1-mforney@mforney.org> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 13/01/2021 22.56, Michael Forney wrote: > Prior to 2a4b472c3c, sys/signal.h was only included on OpenBSD > (apart from two .c files). The POSIX standard location for this > header is just and in fact, OpenBSD's signal.h includes > sys/signal.h itself. > > Unconditionally including on musl causes warnings > for just about every source file: > > /usr/include/sys/signal.h:1:2: warning: #warning redirecting incorrect #include to [-Wcpp] > 1 | #warning redirecting incorrect #include to > | ^~~~~~~ > > Since there don't seem to be any platforms which require including > in addition to , and some platforms like > Haiku lack it completely, just remove it. > > Tested building on OpenBSD after removing this include. > > Signed-off-by: Michael Forney > Reviewed-by: Eric Blake > --- > Changes since v1: rebase on latest master > > include/qemu/osdep.h | 4 ---- > meson.build | 1 - > 2 files changed, 5 deletions(-) > > diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h > index f9ec8c84e9..a434382c58 100644 > --- a/include/qemu/osdep.h > +++ b/include/qemu/osdep.h > @@ -104,10 +104,6 @@ extern int daemon(int, int); > #include > #include > > -#ifdef HAVE_SYS_SIGNAL_H > -#include > -#endif > - > #ifndef _WIN32 > #include > #else > diff --git a/meson.build b/meson.build > index 3d889857a0..af2bc89741 100644 > --- a/meson.build > +++ b/meson.build > @@ -1113,7 +1113,6 @@ config_host_data.set('HAVE_DRM_H', cc.has_header('libdrm/drm.h')) > config_host_data.set('HAVE_PTY_H', cc.has_header('pty.h')) > config_host_data.set('HAVE_SYS_IOCCOM_H', cc.has_header('sys/ioccom.h')) > config_host_data.set('HAVE_SYS_KCOV_H', cc.has_header('sys/kcov.h')) > -config_host_data.set('HAVE_SYS_SIGNAL_H', cc.has_header('sys/signal.h')) > > ignored = ['CONFIG_QEMU_INTERP_PREFIX'] # actually per-target > arrays = ['CONFIG_AUDIO_DRIVERS', 'CONFIG_BDRV_RW_WHITELIST', 'CONFIG_BDRV_RO_WHITELIST'] > Reviewed-by: Thomas Huth