From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] remove unnecessary extern "C" blocks
Date: Wed, 11 Jan 2023 10:14:11 +0100 [thread overview]
Message-ID: <08ae1223-2721-b10c-ff2b-91a62bd83070@redhat.com> (raw)
In-Reply-To: <CAFEAcA9VCBqarUPzRrTx5ZXXFV8bdijge6zi=YUSrcirtv6bWA@mail.gmail.com>
On 1/10/23 11:53, Peter Maydell wrote:
> On Tue, 10 Jan 2023 at 09:33, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>
>> A handful of header files in QEMU are wrapped with extern "C" blocks.
>> These are not necessary: there are C++ source files anymore in QEMU,
>> and even where there were some, they did not include most of these
>> files anyway.
>
> Any reason not to also take out the extern "C" block in osdep.h
> and the uses of QEMU_EXTERN_C ?
qemu/osdep.h is still included by the C++ sources in qga/vss-win32.
Paolo
next prev parent reply other threads:[~2023-01-11 9:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 8:49 [PATCH] remove unnecessary extern "C" blocks Paolo Bonzini
2023-01-10 9:38 ` Daniel P. Berrangé
2023-01-10 10:53 ` Peter Maydell
2023-01-11 9:14 ` Paolo Bonzini [this message]
2023-01-12 11:05 ` Peter Maydell
2023-01-13 8:27 ` Paolo Bonzini
2023-01-12 13:10 ` David Woodhouse
2023-01-12 13:14 ` Peter Maydell
2023-01-12 13:17 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08ae1223-2721-b10c-ff2b-91a62bd83070@redhat.com \
--to=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).