From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: "David Gibson" <david@gibson.dropbear.id.au>,
"Frédéric Barrat" <fbarrat@linux.ibm.com>,
"Cédric Le Goater" <clg@kaod.org>,
"Harsh Prateek Bora" <harshpb@linux.ibm.com>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Daniel Henrique Barboza" <danielhb413@gmail.com>,
qemu-ppc@nongnu.org
Subject: Re: [PATCH 4/6] hw/ppc/pnv: Do not use SysBus API to map local MMIO region
Date: Thu, 19 Oct 2023 07:44:16 +0200 [thread overview]
Message-ID: <08b2004d-e4a1-4c72-af6a-b27fa9896a4f@redhat.com> (raw)
In-Reply-To: <20231018133059.85765-5-philmd@linaro.org>
On 18/10/2023 15.30, Philippe Mathieu-Daudé wrote:
> There is no point in exposing an internal MMIO region via
> SysBus and directly mapping it in the very same device.
>
> Just map it without using the SysBus API.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> hw/ppc/pnv.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2023-10-19 5:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 13:30 [PATCH 0/6] hw/ppc: SysBus simplifications Philippe Mathieu-Daudé
2023-10-18 13:30 ` [PATCH 1/6] hw/ppc/pnv_xscom: Rename pnv_xscom_realize(Error **) -> pnv_xscom_init() Philippe Mathieu-Daudé
2023-10-19 5:41 ` Thomas Huth
2023-10-18 13:30 ` [PATCH 2/6] hw/ppc/pnv_xscom: Move sysbus_mmio_map() call within pnv_xscom_init() Philippe Mathieu-Daudé
2023-10-19 5:42 ` Thomas Huth
2023-10-18 13:30 ` [PATCH 3/6] hw/ppc/pnv_xscom: Do not use SysBus API to map local MMIO region Philippe Mathieu-Daudé
2023-10-19 5:43 ` Thomas Huth
2023-10-18 13:30 ` [PATCH 4/6] hw/ppc/pnv: " Philippe Mathieu-Daudé
2023-10-19 5:44 ` Thomas Huth [this message]
2023-10-18 13:30 ` [PATCH 5/6] hw/intc/spapr_xive: Move sysbus_init_mmio() calls around Philippe Mathieu-Daudé
2023-10-19 5:45 ` Thomas Huth
2023-10-18 13:30 ` [PATCH 6/6] hw/intc/spapr_xive: Do not use SysBus API to map local MMIO region Philippe Mathieu-Daudé
2023-10-19 5:46 ` Thomas Huth
2023-10-18 18:28 ` [PATCH 0/6] hw/ppc: SysBus simplifications Philippe Mathieu-Daudé
2023-10-18 23:52 ` Richard Henderson
2023-10-19 8:28 ` LIU Zhiwei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08b2004d-e4a1-4c72-af6a-b27fa9896a4f@redhat.com \
--to=thuth@redhat.com \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=fbarrat@linux.ibm.com \
--cc=harshpb@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).