From: Richard Henderson <richard.henderson@linaro.org>
To: Georg Kotheimer <georg.kotheimer@kernkonzept.com>,
qemu-devel@nongnu.org, qemu-riscv@nongnu.org
Cc: Alistair Francis <alistair.francis@wdc.com>
Subject: Re: [PATCH] target/riscv: Prevent lost illegal instruction exceptions
Date: Fri, 19 Mar 2021 09:22:41 -0600 [thread overview]
Message-ID: <08b6fe4d-03bb-04d9-e44b-f939f839278d@linaro.org> (raw)
In-Reply-To: <20210316150354.1948265-1-georg.kotheimer@kernkonzept.com>
On 3/16/21 9:03 AM, Georg Kotheimer wrote:
> When decode_insn16() fails, we fall back to decode_RV32_64C() for
> further compressed instruction decoding.
I think this is all dead code now. Certainly c.ld/c.sd are in insn16-64.decode
and c.flw/c.fsw are in insn16-32.decode.
Digging, we failed to remove these functions here: f330433b363.
You are absolutely right there's a missing
> if (!decode_insn16(ctx, opcode)) {
> /* fall back to old decoder */
> - decode_RV32_64C(ctx, opcode);
> + if (!decode_RV32_64C(ctx, opcode)) {
> + gen_exception_illegal(ctx);
exception here, but we can remove the last remnants of the old decoder instead
of patching them.
r~
prev parent reply other threads:[~2021-03-19 15:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 15:03 [PATCH] target/riscv: Prevent lost illegal instruction exceptions Georg Kotheimer
2021-03-19 13:52 ` Alistair Francis
2021-03-19 15:22 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08b6fe4d-03bb-04d9-e44b-f939f839278d@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=georg.kotheimer@kernkonzept.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).