From: Francesco Lavra <francescolavra.fl@gmail.com>
To: xiaoyao.li@intel.com
Cc: armbru@redhat.com, berrange@redhat.com, chenhuacai@kernel.org,
eblake@redhat.com, francescolavra.fl@gmail.com,
imammedo@redhat.com, kvm@vger.kernel.org, mst@redhat.com,
mtosatti@redhat.com, pbonzini@redhat.com,
peter.maydell@linaro.org, philmd@linaro.org,
qemu-devel@nongnu.org, rick.p.edgecombe@intel.com,
zhao1.liu@intel.com
Subject: Re: [PATCH v7 05/52] i386/tdx: Get tdx_capabilities via KVM_TDX_CAPABILITIES
Date: Tue, 18 Feb 2025 20:21:37 +0100 [thread overview]
Message-ID: <08bf7f3061459af5f05fabf0d3796b77d8034587.camel@gmail.com> (raw)
In-Reply-To: <20250124132048.3229049-6-xiaoyao.li@intel.com>
On Fri, 24 Jan 2025 08:20:01 -0500, Xiaoyao Li wrote:
> diff --git a/target/i386/kvm/tdx.c b/target/i386/kvm/tdx.c
> index 4ff94860815d..bd212abab865 100644
> --- a/target/i386/kvm/tdx.c
> +++ b/target/i386/kvm/tdx.c
> @@ -10,17 +10,122 @@
> */
>
> #include "qemu/osdep.h"
> +#include "qemu/error-report.h"
> +#include "qapi/error.h"
> #include "qom/object_interfaces.h"
>
> #include "hw/i386/x86.h"
> #include "kvm_i386.h"
> #include "tdx.h"
>
> +static struct kvm_tdx_capabilities *tdx_caps;
Instead of a static variable, this should be a member of the TdxGuest
struct.
next prev parent reply other threads:[~2025-02-18 19:22 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-24 13:19 [PATCH v7 00/52] QEMU TDX support Xiaoyao Li
2025-01-24 13:19 ` [PATCH v7 01/52] *** HACK *** linux-headers: Update headers to pull in TDX API changes Xiaoyao Li
2025-01-24 13:19 ` [PATCH v7 02/52] i386: Introduce tdx-guest object Xiaoyao Li
2025-01-24 13:19 ` [PATCH v7 03/52] i386/tdx: Implement tdx_kvm_type() for TDX Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 04/52] i386/tdx: Implement tdx_kvm_init() to initialize TDX VM context Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 05/52] i386/tdx: Get tdx_capabilities via KVM_TDX_CAPABILITIES Xiaoyao Li
2025-02-18 19:21 ` Francesco Lavra [this message]
2025-02-25 8:59 ` Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 06/52] i386/tdx: Introduce is_tdx_vm() helper and cache tdx_guest object Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 07/52] kvm: Introduce kvm_arch_pre_create_vcpu() Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 08/52] i386/tdx: Initialize TDX before creating TD vcpus Xiaoyao Li
2025-02-19 10:14 ` Francesco Lavra
2025-02-25 9:55 ` Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 09/52] i386/tdx: Add property sept-ve-disable for tdx-guest object Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 10/52] i386/tdx: Make sept_ve_disable set by default Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 11/52] i386/tdx: Wire CPU features up with attributes of TD guest Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 12/52] i386/tdx: Validate TD attributes Xiaoyao Li
2025-02-05 9:06 ` Markus Armbruster
2025-02-05 10:29 ` Xiaoyao Li
2025-02-05 10:31 ` Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 13/52] i386/tdx: Set APIC bus rate to match with what TDX module enforces Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 14/52] i386/tdx: Implement user specified tsc frequency Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 15/52] i386/tdx: load TDVF for TD guest Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 16/52] i386/tdvf: Introduce function to parse TDVF metadata Xiaoyao Li
2025-02-19 10:58 ` Francesco Lavra
2025-02-25 11:59 ` Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 17/52] i386/tdx: Parse TDVF metadata for TDX VM Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 18/52] i386/tdx: Don't initialize pc.rom for TDX VMs Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 19/52] i386/tdx: Track mem_ptr for each firmware entry of TDVF Xiaoyao Li
2025-02-19 11:26 ` Francesco Lavra
2025-02-26 9:07 ` Xiaoyao Li
2025-02-19 18:40 ` Francesco Lavra
2025-02-26 9:08 ` Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 20/52] i386/tdx: Track RAM entries for TDX VM Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 21/52] headers: Add definitions from UEFI spec for volumes, resources, etc Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 22/52] i386/tdx: Setup the TD HOB list Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 23/52] i386/tdx: Add TDVF memory via KVM_TDX_INIT_MEM_REGION Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 24/52] i386/tdx: Call KVM_TDX_INIT_VCPU to initialize TDX vcpu Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 25/52] i386/tdx: Finalize TDX VM Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 26/52] i386/tdx: Enable user exit on KVM_HC_MAP_GPA_RANGE Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 27/52] i386/tdx: Handle KVM_SYSTEM_EVENT_TDX_FATAL Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 28/52] i386/tdx: Wire TDX_REPORT_FATAL_ERROR with GuestPanic facility Xiaoyao Li
2025-02-05 9:19 ` Markus Armbruster
2025-02-05 10:19 ` Xiaoyao Li
2025-02-27 16:30 ` Francesco Lavra
2025-03-03 2:36 ` Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 29/52] i386/cpu: introduce x86_confidential_guest_cpu_instance_init() Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 30/52] i386/tdx: implement tdx_cpu_instance_init() Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 31/52] i386/cpu: Introduce enable_cpuid_0x1f to force exposing CPUID 0x1f Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 32/52] i386/tdx: Force " Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 33/52] i386/tdx: Set kvm_readonly_mem_enabled to false for TDX VM Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 34/52] i386/tdx: Disable SMM for TDX VMs Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 35/52] i386/tdx: Disable PIC " Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 36/52] i386/tdx: Don't synchronize guest tsc for TDs Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 37/52] i386/tdx: Only configure MSR_IA32_UCODE_REV in kvm_init_msrs() " Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 38/52] i386/apic: Skip kvm_apic_put() for TDX Xiaoyao Li
2025-02-27 16:57 ` Francesco Lavra
2025-03-03 2:42 ` Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 39/52] cpu: Don't set vcpu_dirty when guest_state_protected Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 40/52] i386/cgs: Rename *mask_cpuid_features() to *adjust_cpuid_features() Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 41/52] i386/tdx: Implement adjust_cpuid_features() for TDX Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 42/52] i386/tdx: Apply TDX fixed0 and fixed1 information to supported CPUIDs Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 43/52] i386/tdx: Mask off CPUID bits by unsupported TD Attributes Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 44/52] i386/cpu: Move CPUID_XSTATE_XSS_MASK to header file and introduce CPUID_XSTATE_MASK Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 45/52] i386/tdx: Mask off CPUID bits by unsupported XFAM Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 46/52] i386/tdx: Mark the configurable bit not reported by KVM as unsupported Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 47/52] i386/cgs: Introduce x86_confidential_guest_check_features() Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 48/52] i386/tdx: Fetch and validate CPUID of TD guest Xiaoyao Li
2025-02-05 9:28 ` Markus Armbruster
2025-02-05 10:29 ` Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 49/52] i386/tdx: Don't treat SYSCALL as unavailable Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 50/52] i386/tdx: Make invtsc default on Xiaoyao Li
2025-01-24 13:20 ` [PATCH v7 51/52] i386/tdx: Validate phys_bits against host value Xiaoyao Li
2025-01-31 18:27 ` Paolo Bonzini
2025-02-02 14:39 ` Xiaoyao Li
2025-02-03 18:15 ` Paolo Bonzini
2025-01-24 13:20 ` [PATCH v7 52/52] docs: Add TDX documentation Xiaoyao Li
2025-03-25 18:46 ` Daniel P. Berrangé
2025-03-26 3:36 ` Xiaoyao Li
2025-03-26 6:48 ` Xiaoyao Li
2025-03-26 9:22 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08bf7f3061459af5f05fabf0d3796b77d8034587.camel@gmail.com \
--to=francescolavra.fl@gmail.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=chenhuacai@kernel.org \
--cc=eblake@redhat.com \
--cc=imammedo@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rick.p.edgecombe@intel.com \
--cc=xiaoyao.li@intel.com \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).