qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Eric Blake <eblake@redhat.com>
Subject: Re: [PATCH] crypto: purge 'loaded' property that was documented as already removed
Date: Wed, 30 Oct 2024 15:50:51 -0300	[thread overview]
Message-ID: <08cb3768-a7a9-4e01-a574-4af2affbbd30@linaro.org> (raw)
In-Reply-To: <20241030084718.2980247-1-berrange@redhat.com>

On 30/10/24 05:47, Daniel P. Berrangé wrote:
> The 'loaded' property on TLS creds and secret objects was marked as
> deprected in 6.0.0 and then marked as removed in 7.1.0.
> 
> Except it wasn't actually removed, it was just made read-only, while
> claiming it was removed. Finish the long overdue removal job.
> 
> Fixes: 0310641c06dd5f7ea031b2b6170cb2edc63e4cea
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>   crypto/secret_common.c          | 12 --------
>   crypto/tlscredsanon.c           | 35 ----------------------
>   crypto/tlscredspsk.c            | 34 ----------------------
>   crypto/tlscredsx509.c           | 30 -------------------
>   docs/about/removed-features.rst |  6 ++--
>   qapi/crypto.json                | 51 +++------------------------------
>   6 files changed, 7 insertions(+), 161 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>



  reply	other threads:[~2024-10-30 18:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-30  8:47 [PATCH] crypto: purge 'loaded' property that was documented as already removed Daniel P. Berrangé
2024-10-30 18:50 ` Philippe Mathieu-Daudé [this message]
2024-11-04  8:09 ` Markus Armbruster
2024-11-05 15:07   ` Daniel P. Berrangé
2024-11-07 11:17     ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=08cb3768-a7a9-4e01-a574-4af2affbbd30@linaro.org \
    --to=philmd@linaro.org \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=eblake@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).