* [PATCH] trace: Do not try to include QMP commands in user emulation binaries
@ 2022-12-20 15:04 Philippe Mathieu-Daudé
2022-12-20 15:06 ` Philippe Mathieu-Daudé
2022-12-21 1:04 ` Richard Henderson
0 siblings, 2 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2022-12-20 15:04 UTC (permalink / raw)
To: qemu-devel
Cc: Stefan Hajnoczi, Markus Armbruster, Laurent Vivier,
Philippe Mathieu-Daudé
QMP is not available on user emulation; there is not monitor.
Besides, since commit a0e61807a3 ("qapi: Remove QMP events
and commands from user-mode builds") we don't generate the
qapi-commands-trace.h header in a user-emulation-only build.
Remove the QMP trace commands from qemu-user binaries.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
trace/meson.build | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/trace/meson.build b/trace/meson.build
index 26b54714d5..4385afbff0 100644
--- a/trace/meson.build
+++ b/trace/meson.build
@@ -88,4 +88,6 @@ if 'ftrace' in get_option('trace_backends')
trace_ss.add(files('ftrace.c'))
endif
trace_ss.add(files('control.c'))
-trace_ss.add(files('qmp.c'))
+if have_system or have_tools or have_ga
+ trace_ss.add(files('qmp.c'))
+endif
--
2.38.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] trace: Do not try to include QMP commands in user emulation binaries
2022-12-20 15:04 [PATCH] trace: Do not try to include QMP commands in user emulation binaries Philippe Mathieu-Daudé
@ 2022-12-20 15:06 ` Philippe Mathieu-Daudé
2022-12-21 1:04 ` Richard Henderson
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2022-12-20 15:06 UTC (permalink / raw)
To: qemu-devel, Paolo Bonzini
Cc: Stefan Hajnoczi, Markus Armbruster, Laurent Vivier
On 20/12/22 16:04, Philippe Mathieu-Daudé wrote:
> QMP is not available on user emulation; there is not monitor.
> Besides, since commit a0e61807a3 ("qapi: Remove QMP events
> and commands from user-mode builds") we don't generate the
> qapi-commands-trace.h header in a user-emulation-only build.
>
> Remove the QMP trace commands from qemu-user binaries.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> trace/meson.build | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/trace/meson.build b/trace/meson.build
> index 26b54714d5..4385afbff0 100644
> --- a/trace/meson.build
> +++ b/trace/meson.build
> @@ -88,4 +88,6 @@ if 'ftrace' in get_option('trace_backends')
> trace_ss.add(files('ftrace.c'))
> endif
> trace_ss.add(files('control.c'))
> -trace_ss.add(files('qmp.c'))
> +if have_system or have_tools or have_ga
Maybe this pattern deserves adding a variable similar to:
have_monitor = have_system or have_tools or have_ga
> + trace_ss.add(files('qmp.c'))
> +endif
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] trace: Do not try to include QMP commands in user emulation binaries
2022-12-20 15:04 [PATCH] trace: Do not try to include QMP commands in user emulation binaries Philippe Mathieu-Daudé
2022-12-20 15:06 ` Philippe Mathieu-Daudé
@ 2022-12-21 1:04 ` Richard Henderson
1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2022-12-21 1:04 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Stefan Hajnoczi, Markus Armbruster, Laurent Vivier
On 12/20/22 07:04, Philippe Mathieu-Daudé wrote:
> QMP is not available on user emulation; there is not monitor.
> Besides, since commit a0e61807a3 ("qapi: Remove QMP events
> and commands from user-mode builds") we don't generate the
> qapi-commands-trace.h header in a user-emulation-only build.
>
> Remove the QMP trace commands from qemu-user binaries.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> trace/meson.build | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Acked-by: Richard Henderson <richard.henderson@linaro.org>
r~
>
> diff --git a/trace/meson.build b/trace/meson.build
> index 26b54714d5..4385afbff0 100644
> --- a/trace/meson.build
> +++ b/trace/meson.build
> @@ -88,4 +88,6 @@ if 'ftrace' in get_option('trace_backends')
> trace_ss.add(files('ftrace.c'))
> endif
> trace_ss.add(files('control.c'))
> -trace_ss.add(files('qmp.c'))
> +if have_system or have_tools or have_ga
> + trace_ss.add(files('qmp.c'))
> +endif
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-21 1:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-20 15:04 [PATCH] trace: Do not try to include QMP commands in user emulation binaries Philippe Mathieu-Daudé
2022-12-20 15:06 ` Philippe Mathieu-Daudé
2022-12-21 1:04 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).