From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCA73C433FE for ; Mon, 7 Dec 2020 21:04:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D4D12388C for ; Mon, 7 Dec 2020 21:04:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D4D12388C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40748 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kmNgh-00028g-E7 for qemu-devel@archiver.kernel.org; Mon, 07 Dec 2020 16:04:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46206) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kmNeW-0001Bh-3Y for qemu-devel@nongnu.org; Mon, 07 Dec 2020 16:02:37 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:23398) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kmNeT-0004d0-I1 for qemu-devel@nongnu.org; Mon, 07 Dec 2020 16:02:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607374949; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kYkdnpQAroHrBV+Z7JwuA/j+zFSvDi5QKLecYRVbKdA=; b=POO5BzYnweZxEjZzAEIVJNqHmm78yw0XOuhtVo+DmnweyhMr8w/frOxxWadAH0mW8ndiW6 rP4StGA9UmoZb+mtdFVAlhaHhxYa8l98y0dGAa6Fh6o9+dk0RK6fJkc2+jDbhkfv30a2RE UwQ6K1dQABoUav76MwJEn4hcN/BoySY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-141-Rpudpto2P6ia5ovKZppO9Q-1; Mon, 07 Dec 2020 16:02:25 -0500 X-MC-Unique: Rpudpto2P6ia5ovKZppO9Q-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E72DA8144E2; Mon, 7 Dec 2020 21:02:23 +0000 (UTC) Received: from [10.10.116.117] (ovpn-116-117.rdu2.redhat.com [10.10.116.117]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1E9D85D6AB; Mon, 7 Dec 2020 21:02:22 +0000 (UTC) Subject: Re: [RFC PATCH] python: add __repr__ to ConsoleSocket to aid debugging To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-devel@nongnu.org References: <20201207200737.5090-1-alex.bennee@linaro.org> From: John Snow Message-ID: <092ecec7-d4a3-f345-7619-dab4c9a43f69@redhat.com> Date: Mon, 7 Dec 2020 16:02:22 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201207200737.5090-1-alex.bennee@linaro.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , Cleber Rosa Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 12/7/20 3:07 PM, Alex Bennée wrote: > While attempting to debug some console weirdness I thought it would be > worth making it easier to see what it had inside. > > Signed-off-by: Alex Bennée > --- > python/qemu/console_socket.py | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/python/qemu/console_socket.py b/python/qemu/console_socket.py > index f060d79e06..77966d1fe9 100644 > --- a/python/qemu/console_socket.py > +++ b/python/qemu/console_socket.py > @@ -45,6 +45,14 @@ class ConsoleSocket(socket.socket): > if drain: > self._drain_thread = self._thread_start() > > + def __repr__(self): def __repr__(self) -> str: > + s = super(ConsoleSocket, self).__repr__() Use python3-style super(): super().__repr__() > + s = s.rstrip(">") > + s += ", logfile=%s" % (self._logfile) > + s += ", drain_thread=%s" % (self._drain_thread) > + s += ">" > + return s > + Reviewed-by: John Snow feel free to take this through your testing tree. --js