From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DDF9C4360C for ; Wed, 25 Sep 2019 21:34:34 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 21D2C21D80 for ; Wed, 25 Sep 2019 21:34:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 21D2C21D80 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57512 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iDEvh-0004OF-8V for qemu-devel@archiver.kernel.org; Wed, 25 Sep 2019 17:34:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58919) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iDEsu-0002Gv-LQ for qemu-devel@nongnu.org; Wed, 25 Sep 2019 17:31:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iDEsq-0001eR-Qr for qemu-devel@nongnu.org; Wed, 25 Sep 2019 17:31:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47642) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iDEsh-0001at-Uq; Wed, 25 Sep 2019 17:31:28 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8916E3090FC9; Wed, 25 Sep 2019 21:31:26 +0000 (UTC) Received: from [10.3.116.249] (ovpn-116-249.phx2.redhat.com [10.3.116.249]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 33EA01001B00; Wed, 25 Sep 2019 21:31:26 +0000 (UTC) Subject: Re: [PATCH 3/3] iotests: Use stat -c %b in 125 To: Max Reitz , qemu-block@nongnu.org References: <20190925183231.11196-1-mreitz@redhat.com> <20190925183231.11196-4-mreitz@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: <0930fbf9-a3cb-dd1a-81fe-5c8710ee0c46@redhat.com> Date: Wed, 25 Sep 2019 16:31:25 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <20190925183231.11196-4-mreitz@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Wed, 25 Sep 2019 21:31:26 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/25/19 1:32 PM, Max Reitz wrote: > 125 should not use qemu-img to get the on-disk image size, because that > reports it in a human-readable format that is useless to us. Just use > stat instead (like we do to get the image file length). > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/125 | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/tests/qemu-iotests/125 b/tests/qemu-iotests/125 > index 0ef51f1e21..4e31aa4e5f 100755 > --- a/tests/qemu-iotests/125 > +++ b/tests/qemu-iotests/125 > @@ -34,8 +34,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15 > > get_image_size_on_host() > { > - $QEMU_IMG info -f "$IMGFMT" "$TEST_IMG" | grep "disk size" \ > - | sed -e 's/^[^0-9]*\([0-9]\+\).*$/\1/' > + echo $(($(stat -c '%b * %B' "$TEST_IMG_FILE"))) Cute use of $(()) around $(). Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org