From: Eric Blake <eblake@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 1/2] qapi: add missing trace_visit_type_enum() call
Date: Thu, 26 Jan 2017 11:49:36 -0600 [thread overview]
Message-ID: <093d4dea-2486-8542-fb38-2d71d3d18ef8@redhat.com> (raw)
In-Reply-To: <20170126171613.1399-2-stefanha@redhat.com>
On 01/26/2017 11:16 AM, Stefan Hajnoczi wrote:
> A trace event exists for enums but it's never called. This patch fixes
> this oversight so that enums are traced just like the other QAPI types.
>
> Suggested-by: Daniel P. Berrange <berrange@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> qapi/qapi-visit-core.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/qapi/qapi-visit-core.c b/qapi/qapi-visit-core.c
> index 63bd97b..e6e93f0 100644
> --- a/qapi/qapi-visit-core.c
> +++ b/qapi/qapi-visit-core.c
> @@ -374,6 +374,7 @@ void visit_type_enum(Visitor *v, const char *name, int *obj,
> const char *const strings[], Error **errp)
> {
> assert(obj && strings);
> + trace_visit_type_enum(v, name, obj);
> switch (v->type) {
> case VISITOR_INPUT:
> input_type_enum(v, name, obj, strings, errp);
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
next prev parent reply other threads:[~2017-01-26 17:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 17:16 [Qemu-devel] [PATCH v2 0/2] trace: clean up trace-events files Stefan Hajnoczi
2017-01-26 17:16 ` [Qemu-devel] [PATCH v2 1/2] qapi: add missing trace_visit_type_enum() call Stefan Hajnoczi
2017-01-26 17:49 ` Eric Blake [this message]
2017-01-26 17:16 ` [Qemu-devel] [PATCH v2 2/2] trace: clean up trace-events files Stefan Hajnoczi
2017-01-26 18:55 ` Eric Blake
2017-01-31 17:15 ` [Qemu-devel] [PATCH v2 0/2] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=093d4dea-2486-8542-fb38-2d71d3d18ef8@redhat.com \
--to=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).