qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: Fabrice Bellard <fabrice@bellard.org>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] enable SVM EFER bit
Date: Wed, 4 Jun 2008 16:30:56 +0200	[thread overview]
Message-ID: <094D0841-ED78-4BF0-9713-800C5E9E444F@suse.de> (raw)
In-Reply-To: <4846925C.5020605@bellard.org>


On Jun 4, 2008, at 3:02 PM, Fabrice Bellard wrote:

> Alexander Graf wrote:
>> Due to the recently introduces checks for SVM activation, the SVM  
>> instructions currently throw a #UD exception if they are not  
>> activated. The activation happens through a write to the EFER which  
>> does not support the SVM bit yet.
>> This patch adds the SVME bit to the EFER MSR write. It makes KVM  
>> work for me again.
>
> OK for the problem, but the fix is not OK because you don't  
> synchronize the hflags. It is strange that SVM can even work with  
> that... I am working on a better fix.

a write to MSR_EFER calls cpu_load_efer() which updates the hflags.

Alex

  reply	other threads:[~2008-06-04 14:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-03 15:02 [Qemu-devel] [PATCH] enable SVM EFER bit Alexander Graf
2008-06-03 19:11 ` Anthony Liguori
2008-06-04 13:02 ` [Qemu-devel] " Fabrice Bellard
2008-06-04 14:30   ` Alexander Graf [this message]
2008-06-04 14:33   ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=094D0841-ED78-4BF0-9713-800C5E9E444F@suse.de \
    --to=agraf@suse.de \
    --cc=fabrice@bellard.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).