From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"John Snow" <jsnow@redhat.com>,
qemu-arm@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
"Cleber Rosa" <crosa@redhat.com>
Subject: Re: [RFC PATCH] tests/functional: Generic method to check required devices availability
Date: Mon, 14 Apr 2025 08:15:49 +0200 [thread overview]
Message-ID: <095590ec-a705-400f-bf05-2e5bfde34e32@redhat.com> (raw)
In-Reply-To: <20250219142412.77536-1-philmd@linaro.org>
On 19/02/2025 15.24, Philippe Mathieu-Daudé wrote:
> Not all binaries contain the same set of devices. Since some
> tests depend on specific devices, we need to check their
> availability in the binary.
>
> QemuSystemTest::require_device() allows for system tests to
> explicitly check for a particular device. Add a similar
> check_required_devices() method which check all devices
> requested on the command line. If a device is missing, the
> test is skipped.
>
> Example running test_aarch64_virt.py on macOS:
>
> ok 1 test_aarch64_virt.Aarch64VirtMachine.test_aarch64_virt_with_gpu # SKIP no support for device virtio-gpu-gl-pci
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> Just an idea to see if we can avoid manual require_device() calls.
> However not having a device in binary might also be a bug, so RFC...
I'm also a little bit torn by this question ... let's keep it explicit for
now, but if the require_device() calls get too annoying one day, we can
reconsider.
Thomas
prev parent reply other threads:[~2025-04-14 6:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 14:24 [RFC PATCH] tests/functional: Generic method to check required devices availability Philippe Mathieu-Daudé
2025-04-14 6:15 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=095590ec-a705-400f-bf05-2e5bfde34e32@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=crosa@redhat.com \
--cc=jsnow@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).