From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: "Thomas Huth" <thuth@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Aleksandar Rikalo" <arikalo@gmail.com>,
"Huacai Chen" <chenhuacai@kernel.org>,
"Anton Johansson" <anjo@rev.ng>
Subject: Re: [PATCH 11/12] target/mips: Remove target-specific code in mips_cpu_reset_hold()
Date: Thu, 10 Oct 2024 17:22:54 -0300 [thread overview]
Message-ID: <0961097b-d1be-4651-aa95-74d00b62a842@linaro.org> (raw)
In-Reply-To: <dade7ca6-71d0-40f8-9431-5d3fb4685bc9@linaro.org>
On 3/10/24 20:01, Richard Henderson wrote:
> On 9/30/24 02:11, Philippe Mathieu-Daudé wrote:
>> Since all code creating vCPUs now set the 'cpu-big-endian' property,
>> we can remove the target-specific #ifdef'ry in mips_cpu_reset_hold():
>> the CP0C0_BE bit is set using the property cpu->is_big_endian value.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> ---
>> target/mips/cpu.c | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/target/mips/cpu.c b/target/mips/cpu.c
>> index 02e2e72f2d..9724e71a5e 100644
>> --- a/target/mips/cpu.c
>> +++ b/target/mips/cpu.c
>> @@ -202,9 +202,6 @@ static void mips_cpu_reset_hold(Object *obj,
>> ResetType type)
>> env->CP0_PRid = env->cpu_model->CP0_PRid;
>> env->CP0_Config0 = deposit32(env->cpu_model->CP0_Config0,
>> CP0C0_BE, 1, cpu->is_big_endian);
>> -#if TARGET_BIG_ENDIAN
>> - env->CP0_Config0 |= (1 << CP0C0_BE);
>> -#endif
>> env->CP0_Config1 = env->cpu_model->CP0_Config1;
>> env->CP0_Config2 = env->cpu_model->CP0_Config2;
>> env->CP0_Config3 = env->cpu_model->CP0_Config3;
>
> I think this must be merged into patch 8, or patch 8 doesn't work.
Correct.
next prev parent reply other threads:[~2024-10-10 20:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 9:10 [PATCH 00/12] target/mips: Remove target-specific endianness knowledge Philippe Mathieu-Daudé
2024-09-30 9:10 ` [PATCH 01/12] target/mips: Declare cpu_is_bigendian_env() in 'internal.h' Philippe Mathieu-Daudé
2024-10-03 22:52 ` Richard Henderson
2024-09-30 9:10 ` [PATCH 02/12] target/mips: Introduce mo_endian_env() helper Philippe Mathieu-Daudé
2024-09-30 9:10 ` [PATCH 03/12] target/mips: Replace MO_TE by mo_endian_env() in get_pte() Philippe Mathieu-Daudé
2024-09-30 9:10 ` [PATCH 04/12] target/mips: Convert mips16e decr_and_load/store() macros to functions Philippe Mathieu-Daudé
2024-10-03 22:55 ` Richard Henderson
2024-09-30 9:10 ` [PATCH 05/12] target/mips: Introduce mo_endian() helper Philippe Mathieu-Daudé
2024-10-03 22:56 ` Richard Henderson
2024-09-30 9:10 ` [PATCH 06/12] target/mips: Explode MO_TExx -> MO_TE | MO_xx Philippe Mathieu-Daudé
2024-10-01 9:56 ` Philippe Mathieu-Daudé
2024-09-30 9:10 ` [PATCH 07/12] target/mips: Replace MO_TE by mo_endian() Philippe Mathieu-Daudé
2024-09-30 9:10 ` [PATCH 08/12] target/mips: Expose MIPSCPU::is_big_endian property Philippe Mathieu-Daudé
2024-10-03 22:59 ` Richard Henderson
2024-09-30 9:10 ` [PATCH 09/12] hw/mips/cps: Set the vCPU 'cpu-big-endian' property Philippe Mathieu-Daudé
2024-09-30 9:10 ` [PATCH 10/12] hw/mips: Have mips_cpu_create_with_clock() take an endianness argument Philippe Mathieu-Daudé
2024-09-30 9:11 ` [PATCH 11/12] target/mips: Remove target-specific code in mips_cpu_reset_hold() Philippe Mathieu-Daudé
2024-10-03 23:01 ` Richard Henderson
2024-10-10 20:22 ` Philippe Mathieu-Daudé [this message]
2024-09-30 9:11 ` [PATCH 12/12] hw/mips/malta: Remove TARGET_BIG_ENDIAN #ifdef'ry Philippe Mathieu-Daudé
2024-09-30 12:25 ` [PATCH 00/12] target/mips: Remove target-specific endianness knowledge Jiaxun Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0961097b-d1be-4651-aa95-74d00b62a842@linaro.org \
--to=philmd@linaro.org \
--cc=anjo@rev.ng \
--cc=arikalo@gmail.com \
--cc=aurelien@aurel32.net \
--cc=chenhuacai@kernel.org \
--cc=hpoussin@reactos.org \
--cc=jiaxun.yang@flygoat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).