From: Eric Blake <eblake@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: Fam Zheng <fam@euphon.net>, Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Jason Wang <jasowang@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>, John Snow <jsnow@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/2] trace: Remove trailing newline in events
Date: Mon, 16 Sep 2019 11:36:55 -0500 [thread overview]
Message-ID: <097f47ce-60a6-109f-e210-0844efed6a32@redhat.com> (raw)
In-Reply-To: <20190916095121.29506-2-philmd@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 726 bytes --]
On 9/16/19 4:51 AM, Philippe Mathieu-Daudé wrote:
> While the tracing frawework does not forbid trailing newline in
framework
> events format string, using them lead to confuse output.
> It is the responsibility of the backend to properly end an event
> line.
Why just trailing newline? Should we not forbid ALL use of newline in a
trace message?
>
> Some of our formats have trailing newlines, remove them.
>
> Reviewed-by: John Snow <jsnow@redhat.com>
> Reviewed-by: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-09-16 16:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-16 9:51 [Qemu-devel] [PATCH v2 0/2] trace: Forbid trailing newline in event format Philippe Mathieu-Daudé
2019-09-16 9:51 ` [Qemu-devel] [PATCH v2 1/2] trace: Remove trailing newline in events Philippe Mathieu-Daudé
2019-09-16 16:36 ` Eric Blake [this message]
2019-09-16 16:40 ` Philippe Mathieu-Daudé
2019-09-16 16:41 ` John Snow
2019-09-18 9:18 ` Stefan Hajnoczi
2019-09-16 9:51 ` [Qemu-devel] [PATCH v2 2/2] trace: Forbid event format ending with newline character Philippe Mathieu-Daudé
2019-09-18 9:21 ` [Qemu-devel] [Qemu-block] [PATCH v2 0/2] trace: Forbid trailing newline in event format Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=097f47ce-60a6-109f-e210-0844efed6a32@redhat.com \
--to=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=jasowang@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).