From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>,
Peter Maydell <peter.maydell@linaro.org>,
qemu-devel <qemu-devel@nongnu.org>,
qemu-arm <qemu-arm@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] hw/arm/virt: Add support for Cortex-A7
Date: Mon, 1 Jul 2019 11:36:06 +0200 [thread overview]
Message-ID: <098adaad-e787-3d5d-a145-5c4999aa32fe@redhat.com> (raw)
In-Reply-To: <fc5404f7-4d1d-c28f-6e48-d8799c82acc0@web.de>
On 6/30/19 5:13 PM, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
>
> No reason to deny this type.
Maybe add "As the A15, it supports the EL2/V7VE features."?
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> hw/arm/virt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 431e2900fd..ed009fa447 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -176,6 +176,7 @@ static const int a15irqmap[] = {
> };
>
> static const char *valid_cpus[] = {
> + ARM_CPU_TYPE_NAME("cortex-a7"),
> ARM_CPU_TYPE_NAME("cortex-a15"),
> ARM_CPU_TYPE_NAME("cortex-a53"),
> ARM_CPU_TYPE_NAME("cortex-a57"),
Should we list here all cpu with arm_feature(ARM_FEATURE_V7VE | V8)? or EL2?
> --
> 2.16.4
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2019-07-01 9:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-30 15:13 [Qemu-devel] [PATCH] hw/arm/virt: Add support for Cortex-A7 Jan Kiszka
2019-07-01 9:36 ` Philippe Mathieu-Daudé [this message]
2019-07-01 11:16 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=098adaad-e787-3d5d-a145-5c4999aa32fe@redhat.com \
--to=philmd@redhat.com \
--cc=jan.kiszka@web.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).