From: David Hildenbrand <david@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Halil Pasic <pasic@linux.ibm.com>, Thomas Huth <thuth@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] s390x/cpu_model: use official name for 8562
Date: Fri, 12 Mar 2021 15:12:20 +0100 [thread overview]
Message-ID: <0990f757-1aaa-790b-641c-698aa9859657@redhat.com> (raw)
In-Reply-To: <20210312145516.6d7a9a63.cohuck@redhat.com>
On 12.03.21 14:55, Cornelia Huck wrote:
> On Fri, 12 Mar 2021 14:48:17 +0100
> Christian Borntraeger <borntraeger@de.ibm.com> wrote:
>
>> On 11.03.21 14:27, Cornelia Huck wrote:
>>> The single-frame z15 is called "z15 T02".
>>>
>>> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
>>
>> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
>>> ---
>>> target/s390x/cpu_models.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c
>>> index dd474c5e9ad1..b59ed4135615 100644
>>> --- a/target/s390x/cpu_models.c
>>> +++ b/target/s390x/cpu_models.c
>>> @@ -87,7 +87,7 @@ static S390CPUDef s390_cpu_defs[] = {
>>> CPUDEF_INIT(0x3906, 14, 2, 47, 0x08000000U, "z14.2", "IBM z14 GA2"),
>>> CPUDEF_INIT(0x3907, 14, 1, 47, 0x08000000U, "z14ZR1", "IBM z14 Model ZR1 GA1"),
>>> CPUDEF_INIT(0x8561, 15, 1, 47, 0x08000000U, "gen15a", "IBM z15 GA1"),
>>
>> you could also change that formn "z15" to "z15 T01"
>>> - CPUDEF_INIT(0x8562, 15, 1, 47, 0x08000000U, "gen15b", "IBM 8562 GA1"),
>>> + CPUDEF_INIT(0x8562, 15, 1, 47, 0x08000000U, "gen15b", "IBM z15 T02 GA1"),
>>> };
>>>
>>> #define QEMU_MAX_CPU_TYPE 0x2964
>>>
>>
>
> I now have:
>
> Author: Cornelia Huck <cohuck@redhat.com>
> Date: Thu Mar 11 14:27:46 2021 +0100
>
> s390x/cpu_model: use official name for 8562
>
> The single-frame z15 is called "z15 T02" (and the multi-frame z15
> "z15 T01").
>
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> Reviewed-by: David Hildenbrand <david@redhat.com>
> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
> Message-Id: <20210311132746.1777754-1-cohuck@redhat.com>
>
> diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c
> index dd474c5e9ad1..050dcf2d42d2 100644
> --- a/target/s390x/cpu_models.c
> +++ b/target/s390x/cpu_models.c
> @@ -86,8 +86,8 @@ static S390CPUDef s390_cpu_defs[] = {
> CPUDEF_INIT(0x3906, 14, 1, 47, 0x08000000U, "z14", "IBM z14 GA1"),
> CPUDEF_INIT(0x3906, 14, 2, 47, 0x08000000U, "z14.2", "IBM z14 GA2"),
> CPUDEF_INIT(0x3907, 14, 1, 47, 0x08000000U, "z14ZR1", "IBM z14 Model ZR1 GA1"),
> - CPUDEF_INIT(0x8561, 15, 1, 47, 0x08000000U, "gen15a", "IBM z15 GA1"),
> - CPUDEF_INIT(0x8562, 15, 1, 47, 0x08000000U, "gen15b", "IBM 8562 GA1"),
> + CPUDEF_INIT(0x8561, 15, 1, 47, 0x08000000U, "gen15a", "IBM z15 T01 GA1"),
> + CPUDEF_INIT(0x8562, 15, 1, 47, 0x08000000U, "gen15b", "IBM z15 T02 GA1"),
> };
>
> #define QEMU_MAX_CPU_TYPE 0x2964
>
LGTM
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2021-03-12 14:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 13:27 [PATCH] s390x/cpu_model: use official name for 8562 Cornelia Huck
2021-03-11 13:30 ` David Hildenbrand
2021-03-12 13:29 ` Cornelia Huck
2021-03-12 13:48 ` Christian Borntraeger
2021-03-12 13:55 ` Cornelia Huck
2021-03-12 14:12 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0990f757-1aaa-790b-641c-698aa9859657@redhat.com \
--to=david@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).