[PATCH v3 0/2] gdbstub: Introduce ldtul_$endian_p() helpers

[PATCH v3 0/2] gdbstub: Introduce ldtul_$endian_p() helpers

[Philippe Mathieu-Daudé]

Only unreviewed patches from v2:
https://lore.kernel.org/qemu-devel/20241004163042.85922-1-philmd@linaro.org/

Philippe Mathieu-Daudé (2):
  exec/tswap: Massage target_needs_bswap() definition
  gdbstub/helpers: Introduce ldtul_$endian_p() helpers

 include/exec/tswap.h      | 2 +-
 include/gdbstub/helpers.h | 4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)

-- 
2.45.2

[PATCH v3 1/2] exec/tswap: Massage target_needs_bswap() definition

[Philippe Mathieu-Daudé]

Invert target_needs_bswap() comparison to match the
COMPILING_PER_TARGET definition (2 lines upper).

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20241004162118.84570-2-philmd@linaro.org>
---
 include/exec/tswap.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/exec/tswap.h b/include/exec/tswap.h
index b7a41913475..ecd4faef015 100644
--- a/include/exec/tswap.h
+++ b/include/exec/tswap.h
@@ -28,7 +28,7 @@ bool target_words_bigendian(void);
 #ifdef COMPILING_PER_TARGET
 #define target_needs_bswap()  (HOST_BIG_ENDIAN != TARGET_BIG_ENDIAN)
 #else
-#define target_needs_bswap()  (target_words_bigendian() != HOST_BIG_ENDIAN)
+#define target_needs_bswap()  (HOST_BIG_ENDIAN != target_words_bigendian())
 #endif /* COMPILING_PER_TARGET */
 
 static inline uint16_t tswap16(uint16_t s)
-- 
2.45.2

Re: [PATCH v3 1/2] exec/tswap: Massage target_needs_bswap() definition

[Richard Henderson]

On 10/10/24 10:52, Philippe Mathieu-Daudé wrote:
> Invert target_needs_bswap() comparison to match the
> COMPILING_PER_TARGET definition (2 lines upper).
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Message-Id: <20241004162118.84570-2-philmd@linaro.org>
> ---
>   include/exec/tswap.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

> 
> diff --git a/include/exec/tswap.h b/include/exec/tswap.h
> index b7a41913475..ecd4faef015 100644
> --- a/include/exec/tswap.h
> +++ b/include/exec/tswap.h
> @@ -28,7 +28,7 @@ bool target_words_bigendian(void);
>   #ifdef COMPILING_PER_TARGET
>   #define target_needs_bswap()  (HOST_BIG_ENDIAN != TARGET_BIG_ENDIAN)
>   #else
> -#define target_needs_bswap()  (target_words_bigendian() != HOST_BIG_ENDIAN)
> +#define target_needs_bswap()  (HOST_BIG_ENDIAN != target_words_bigendian())
>   #endif /* COMPILING_PER_TARGET */
>   
>   static inline uint16_t tswap16(uint16_t s)

[PATCH v3 2/2] gdbstub/helpers: Introduce ldtul_$endian_p() helpers

[Philippe Mathieu-Daudé]

Introduce ldtul_le_p() and ldtul_be_p() to use directly
in place of ldtul_p() when a target endianness is fixed.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 include/gdbstub/helpers.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/include/gdbstub/helpers.h b/include/gdbstub/helpers.h
index 26140ef1ac0..6f7cc48adcb 100644
--- a/include/gdbstub/helpers.h
+++ b/include/gdbstub/helpers.h
@@ -95,9 +95,13 @@ static inline uint8_t *gdb_get_reg_ptr(GByteArray *buf, int len)
 #if TARGET_LONG_BITS == 64
 #define gdb_get_regl(buf, val) gdb_get_reg64(buf, val)
 #define ldtul_p(addr) ldq_p(addr)
+#define ldtul_le_p(addr) ldq_le_p(addr)
+#define ldtul_be_p(addr) ldq_be_p(addr)
 #else
 #define gdb_get_regl(buf, val) gdb_get_reg32(buf, val)
 #define ldtul_p(addr) ldl_p(addr)
+#define ldtul_le_p(addr) ldl_le_p(addr)
+#define ldtul_be_p(addr) ldl_be_p(addr)
 #endif
 
 #endif /* _GDBSTUB_HELPERS_H_ */
-- 
2.45.2

Re: [PATCH v3 2/2] gdbstub/helpers: Introduce ldtul_$endian_p() helpers

[Alex Bennée]

Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> Introduce ldtul_le_p() and ldtul_be_p() to use directly
> in place of ldtul_p() when a target endianness is fixed.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Acked-by: Alex Bennée <alex.bennee@linaro.org>

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro

Re: [PATCH v3 2/2] gdbstub/helpers: Introduce ldtul_$endian_p() helpers

[Richard Henderson]

On 10/10/24 10:52, Philippe Mathieu-Daudé wrote:
> Introduce ldtul_le_p() and ldtul_be_p() to use directly
> in place of ldtul_p() when a target endianness is fixed.
> 
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> ---
>   include/gdbstub/helpers.h | 4 ++++
>   1 file changed, 4 insertions(+)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

Re: [PATCH v3 0/2] gdbstub: Introduce ldtul_$endian_p() helpers

[Pierrick Bouvier]

On 10/10/24 10:52, Philippe Mathieu-Daudé wrote:
> Only unreviewed patches from v2:
> https://lore.kernel.org/qemu-devel/20241004163042.85922-1-philmd@linaro.org/
> 
> Philippe Mathieu-Daudé (2):
>    exec/tswap: Massage target_needs_bswap() definition
>    gdbstub/helpers: Introduce ldtul_$endian_p() helpers
> 
>   include/exec/tswap.h      | 2 +-
>   include/gdbstub/helpers.h | 4 ++++
>   2 files changed, 5 insertions(+), 1 deletion(-)
> 

For the series:
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>

Re: [PATCH v3 0/2] gdbstub: Introduce ldtul_$endian_p() helpers

[Philippe Mathieu-Daudé]

On 10/10/24 14:52, Philippe Mathieu-Daudé wrote:
> Only unreviewed patches from v2:
> https://lore.kernel.org/qemu-devel/20241004163042.85922-1-philmd@linaro.org/
> 
> Philippe Mathieu-Daudé (2):
>    exec/tswap: Massage target_needs_bswap() definition
>    gdbstub/helpers: Introduce ldtul_$endian_p() helpers

Series queued.