Re: [PATCH V1 00/10] privatize migration.h

[Steven Sistare <steven.sistare@oracle.com>]

Please ignore this solo message, I accidentally sent it alone - steve

On 2/27/2024 12:42 PM, Steve Sistare wrote:
> migration/migration.h is the private interface for code in the migration
> sub-directory, but many other clients include it because they need accessors
> that are not exported by the publc interface in include/migration/misc.h.
> Fix that by refactoring accessors and defining new ones as needed.
> 
> After these fixes, no code outside of migration includes migration.h,
> and no code outside of migration uses MigrationState.
> 
> This series depends on the following:
>   * migration patches in the series "allow cpr-reboot for vfio"
>   * singleton patch "migration: export fewer options"
> 
> Steve Sistare (10):
>   migration: remove migration.h references
>   migration: export migration_is_setup_or_active
>   migration: export migration_is_active
>   migration: export migration_is_running
>   migration: export vcpu_dirty_limit_period
>   migration: migration_thread_is_self
>   migration: migration_is_device
>   migration: migration_file_set_error
>   migration: privatize colo interfaces
>   migration: purge MigrationState from public interface
> 
>  hw/vfio/common.c                   | 17 +++-------
>  hw/vfio/container.c                |  1 -
>  hw/vfio/migration.c                | 11 ++-----
>  hw/virtio/vhost-user.c             |  1 -
>  hw/virtio/virtio-balloon.c         |  1 -
>  include/migration/client-options.h |  1 +
>  include/migration/misc.h           | 17 +++++-----
>  migration/colo.c                   | 17 ++++++----
>  migration/migration.c              | 67 ++++++++++++++++++++++++--------------
>  migration/migration.h              |  7 ++--
>  migration/options.c                | 11 +++++--
>  migration/ram.c                    |  5 ++-
>  migration/savevm.c                 |  2 +-
>  net/colo-compare.c                 |  3 +-
>  net/vhost-vdpa.c                   |  3 +-
>  stubs/colo.c                       |  1 -
>  system/dirtylimit.c                | 12 +++----
>  system/qdev-monitor.c              |  1 -
>  target/loongarch/kvm/kvm.c         |  1 -
>  target/riscv/kvm/kvm-cpu.c         |  4 +--
>  tests/unit/test-vmstate.c          |  1 -
>  21 files changed, 96 insertions(+), 88 deletions(-)
>