* [PATCH V1 00/10] privatize migration.h
@ 2024-02-27 17:42 Steve Sistare
2024-02-27 17:44 ` Steven Sistare
0 siblings, 1 reply; 3+ messages in thread
From: Steve Sistare @ 2024-02-27 17:42 UTC (permalink / raw)
To: qemu-devel
Cc: Alex Williamson, Cedric Le Goater, Michael S. Tsirkin,
David Hildenbrand, Peter Xu, Fabiano Rosas, Hailiang Zhang,
Zhang Chen, Li Zhijian, Jason Wang, Hyman Huang, Song Gao,
Alistair Francis, Steve Sistare
migration/migration.h is the private interface for code in the migration
sub-directory, but many other clients include it because they need accessors
that are not exported by the publc interface in include/migration/misc.h.
Fix that by refactoring accessors and defining new ones as needed.
After these fixes, no code outside of migration includes migration.h,
and no code outside of migration uses MigrationState.
This series depends on the following:
* migration patches in the series "allow cpr-reboot for vfio"
* singleton patch "migration: export fewer options"
Steve Sistare (10):
migration: remove migration.h references
migration: export migration_is_setup_or_active
migration: export migration_is_active
migration: export migration_is_running
migration: export vcpu_dirty_limit_period
migration: migration_thread_is_self
migration: migration_is_device
migration: migration_file_set_error
migration: privatize colo interfaces
migration: purge MigrationState from public interface
hw/vfio/common.c | 17 +++-------
hw/vfio/container.c | 1 -
hw/vfio/migration.c | 11 ++-----
hw/virtio/vhost-user.c | 1 -
hw/virtio/virtio-balloon.c | 1 -
include/migration/client-options.h | 1 +
include/migration/misc.h | 17 +++++-----
migration/colo.c | 17 ++++++----
migration/migration.c | 67 ++++++++++++++++++++++++--------------
migration/migration.h | 7 ++--
migration/options.c | 11 +++++--
migration/ram.c | 5 ++-
migration/savevm.c | 2 +-
net/colo-compare.c | 3 +-
net/vhost-vdpa.c | 3 +-
stubs/colo.c | 1 -
system/dirtylimit.c | 12 +++----
system/qdev-monitor.c | 1 -
target/loongarch/kvm/kvm.c | 1 -
target/riscv/kvm/kvm-cpu.c | 4 +--
tests/unit/test-vmstate.c | 1 -
21 files changed, 96 insertions(+), 88 deletions(-)
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH V1 00/10] privatize migration.h
@ 2024-02-27 17:43 Steve Sistare
0 siblings, 0 replies; 3+ messages in thread
From: Steve Sistare @ 2024-02-27 17:43 UTC (permalink / raw)
To: qemu-devel
Cc: Alex Williamson, Cedric Le Goater, Michael S. Tsirkin,
David Hildenbrand, Peter Xu, Fabiano Rosas, Hailiang Zhang,
Zhang Chen, Li Zhijian, Jason Wang, Hyman Huang, Song Gao,
Alistair Francis, Steve Sistare
migration/migration.h is the private interface for code in the migration
sub-directory, but many other clients include it because they need accessors
that are not exported by the publc interface in include/migration/misc.h.
Fix that by refactoring accessors and defining new ones as needed.
After these fixes, no code outside of migration includes migration.h,
and no code outside of migration uses MigrationState.
This series depends on the following:
* migration patches in the series "allow cpr-reboot for vfio"
* singleton patch "migration: export fewer options"
Steve Sistare (10):
migration: remove migration.h references
migration: export migration_is_setup_or_active
migration: export migration_is_active
migration: export migration_is_running
migration: export vcpu_dirty_limit_period
migration: migration_thread_is_self
migration: migration_is_device
migration: migration_file_set_error
migration: privatize colo interfaces
migration: purge MigrationState from public interface
hw/vfio/common.c | 17 +++-------
hw/vfio/container.c | 1 -
hw/vfio/migration.c | 11 ++-----
hw/virtio/vhost-user.c | 1 -
hw/virtio/virtio-balloon.c | 1 -
include/migration/client-options.h | 1 +
include/migration/misc.h | 17 +++++-----
migration/colo.c | 17 ++++++----
migration/migration.c | 67 ++++++++++++++++++++++++--------------
migration/migration.h | 7 ++--
migration/options.c | 11 +++++--
migration/ram.c | 5 ++-
migration/savevm.c | 2 +-
net/colo-compare.c | 3 +-
net/vhost-vdpa.c | 3 +-
stubs/colo.c | 1 -
system/dirtylimit.c | 12 +++----
system/qdev-monitor.c | 1 -
target/loongarch/kvm/kvm.c | 1 -
target/riscv/kvm/kvm-cpu.c | 4 +--
tests/unit/test-vmstate.c | 1 -
21 files changed, 96 insertions(+), 88 deletions(-)
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V1 00/10] privatize migration.h
2024-02-27 17:42 [PATCH V1 00/10] privatize migration.h Steve Sistare
@ 2024-02-27 17:44 ` Steven Sistare
0 siblings, 0 replies; 3+ messages in thread
From: Steven Sistare @ 2024-02-27 17:44 UTC (permalink / raw)
To: qemu-devel
Cc: Alex Williamson, Cedric Le Goater, Michael S. Tsirkin,
David Hildenbrand, Peter Xu, Fabiano Rosas, Hailiang Zhang,
Zhang Chen, Li Zhijian, Jason Wang, Hyman Huang, Song Gao,
Alistair Francis
Please ignore this solo message, I accidentally sent it alone - steve
On 2/27/2024 12:42 PM, Steve Sistare wrote:
> migration/migration.h is the private interface for code in the migration
> sub-directory, but many other clients include it because they need accessors
> that are not exported by the publc interface in include/migration/misc.h.
> Fix that by refactoring accessors and defining new ones as needed.
>
> After these fixes, no code outside of migration includes migration.h,
> and no code outside of migration uses MigrationState.
>
> This series depends on the following:
> * migration patches in the series "allow cpr-reboot for vfio"
> * singleton patch "migration: export fewer options"
>
> Steve Sistare (10):
> migration: remove migration.h references
> migration: export migration_is_setup_or_active
> migration: export migration_is_active
> migration: export migration_is_running
> migration: export vcpu_dirty_limit_period
> migration: migration_thread_is_self
> migration: migration_is_device
> migration: migration_file_set_error
> migration: privatize colo interfaces
> migration: purge MigrationState from public interface
>
> hw/vfio/common.c | 17 +++-------
> hw/vfio/container.c | 1 -
> hw/vfio/migration.c | 11 ++-----
> hw/virtio/vhost-user.c | 1 -
> hw/virtio/virtio-balloon.c | 1 -
> include/migration/client-options.h | 1 +
> include/migration/misc.h | 17 +++++-----
> migration/colo.c | 17 ++++++----
> migration/migration.c | 67 ++++++++++++++++++++++++--------------
> migration/migration.h | 7 ++--
> migration/options.c | 11 +++++--
> migration/ram.c | 5 ++-
> migration/savevm.c | 2 +-
> net/colo-compare.c | 3 +-
> net/vhost-vdpa.c | 3 +-
> stubs/colo.c | 1 -
> system/dirtylimit.c | 12 +++----
> system/qdev-monitor.c | 1 -
> target/loongarch/kvm/kvm.c | 1 -
> target/riscv/kvm/kvm-cpu.c | 4 +--
> tests/unit/test-vmstate.c | 1 -
> 21 files changed, 96 insertions(+), 88 deletions(-)
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-27 17:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-27 17:42 [PATCH V1 00/10] privatize migration.h Steve Sistare
2024-02-27 17:44 ` Steven Sistare
-- strict thread matches above, loose matches on Subject: below --
2024-02-27 17:43 Steve Sistare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).