From: Richard Henderson <richard.henderson@linaro.org>
To: matheus.ferst@eldorado.org.br, qemu-devel@nongnu.org,
qemu-ppc@nongnu.org
Cc: thuth@redhat.com, danielhb413@gmail.com, groug@kaod.org,
philippe.mathieu.daude@gmail.com, clg@kaod.org,
mrezanin@redhat.com, alex.bennee@linaro.org,
david@gibson.dropbear.id.au
Subject: Re: [RFC PATCH v2 3/5] tests/tcg/ppc64le: drop __int128 usage in bcdsub
Date: Thu, 3 Mar 2022 08:57:58 -1000 [thread overview]
Message-ID: <09ba59b1-7e1d-05a9-b96e-514c28a7e6d6@linaro.org> (raw)
In-Reply-To: <20220303172041.1915037-4-matheus.ferst@eldorado.org.br>
On 3/3/22 07:20, matheus.ferst@eldorado.org.br wrote:
> I'm avoiding newer insns like mtvsrdd/mfvsrld to move values between VSR
> and GPR so we can run this test in a POWER8 machine.
This...
> +#define BCDSUB(AH, AL, BH, BL, PS) \
> + asm ("mtvsrd 32, %3\n\t" \
> + "mtvsrd 33, %4\n\t" \
> + "xxmrghd 32, 32, 33\n\t" \
> + "mtvsrd 33, %5\n\t" \
> + "mtvsrd 34, %6\n\t" \
> + "xxmrghd 33, 33, 34\n\t" \
> + "bcdsub. 0, 0, 1, %7\n\t" \
> + "mfocrf %0, 0b10\n\t" \
> + "mfvsrd %1, 32\n\t" \
> + "xxswapd 32, 32\n\t" \
> + "mfvsrd %2, 32\n\t" \
> + : "=r" (cr), "=r" (th), "=r" (tl) \
> + : "r" (AH), "r" (AL), "r" (BH), "r" (BL), "i" (PS) \
> + : "v0", "v1", "v2");
... belongs here as a comment.
> + if (TH || TL) { \
Would be clearer with TH != UNDEF || TL != UNDEF.
Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2022-03-03 19:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-03 17:20 [PATCH v2 0/5] tests/tcg/ppc64le: fix the build of TCG tests with Clang matheus.ferst
2022-03-03 17:20 ` [PATCH v2 1/5] tests/tcg/ppc64le: use inline asm instead of __builtin_mtfsf matheus.ferst
2022-03-03 18:46 ` Richard Henderson
2022-03-03 17:20 ` [PATCH v2 2/5] target/ppc: change xs[n]madd[am]sp to use float64r32_muladd matheus.ferst
2022-03-03 18:49 ` Richard Henderson
2022-03-03 20:53 ` Matheus K. Ferst
2022-03-03 17:20 ` [RFC PATCH v2 3/5] tests/tcg/ppc64le: drop __int128 usage in bcdsub matheus.ferst
2022-03-03 18:57 ` Richard Henderson [this message]
2022-03-03 17:20 ` [RFC PATCH v2 4/5] tests/tcg/ppc64le: emit bcdsub with .long when needed matheus.ferst
2022-03-03 19:19 ` Richard Henderson
2022-03-03 17:20 ` [PATCH v2 5/5] tests/tcg/ppc64le: Use Altivec register names in clobbler list matheus.ferst
2022-03-03 19:30 ` Richard Henderson
2022-03-03 20:53 ` Matheus K. Ferst
2022-03-03 21:05 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09ba59b1-7e1d-05a9-b96e-514c28a7e6d6@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=matheus.ferst@eldorado.org.br \
--cc=mrezanin@redhat.com \
--cc=philippe.mathieu.daude@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).