From: Miles Glenn <milesg@linux.ibm.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
qemu-arm@nongnu.org,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Stefan Berger" <stefanb@linux.vnet.ibm.com>,
"Daniel P . Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH 1/4] hw/gpio/pca9552: Avoid using g_newa()
Date: Thu, 05 Jun 2025 16:03:30 -0500 [thread overview]
Message-ID: <09c3fae7563bb32237862a71414a14f725d052e4.camel@linux.ibm.com> (raw)
In-Reply-To: <20250605193540.59874-2-philmd@linaro.org>
Reviewed-by: Glenn Miles <milesg@linux.ibm.com>
Thanks!
Glenn
On Thu, 2025-06-05 at 21:35 +0200, Philippe Mathieu-Daudé wrote:
> We have pin_count <= PCA955X_PIN_COUNT_MAX. Having
> PCA955X_PIN_COUNT_MAX = 16, it is safe to explicitly
> allocate the char buffer on the stack, without g_newa().
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> hw/gpio/pca9552.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/gpio/pca9552.c b/hw/gpio/pca9552.c
> index d65c0a2e90f..1e10238b2e0 100644
> --- a/hw/gpio/pca9552.c
> +++ b/hw/gpio/pca9552.c
> @@ -76,7 +76,7 @@ static void pca955x_display_pins_status(PCA955xState *s,
> return;
> }
> if (trace_event_get_state_backends(TRACE_PCA955X_GPIO_STATUS)) {
> - char *buf = g_newa(char, k->pin_count + 1);
> + char buf[PCA955X_PIN_COUNT_MAX + 1];
>
> for (i = 0; i < k->pin_count; i++) {
> if (extract32(pins_status, i, 1)) {
next prev parent reply other threads:[~2025-06-05 21:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-05 19:35 [PATCH 0/4] system: Forbid alloca() Philippe Mathieu-Daudé
2025-06-05 19:35 ` [PATCH 1/4] hw/gpio/pca9552: Avoid using g_newa() Philippe Mathieu-Daudé
2025-06-05 21:03 ` Miles Glenn [this message]
2025-06-05 19:35 ` [PATCH 2/4] backends/tpmL Avoid using g_alloca() Philippe Mathieu-Daudé
2025-06-05 21:23 ` BALATON Zoltan
2025-06-06 7:00 ` Philippe Mathieu-Daudé
2025-06-06 8:14 ` Thomas Huth
2025-06-08 19:09 ` Stefan Berger
2025-06-08 19:07 ` Stefan Berger
2025-06-05 19:35 ` [PATCH 3/4] tests/unit/test-char: " Philippe Mathieu-Daudé
2025-06-05 20:53 ` Pierrick Bouvier
2025-06-06 6:09 ` Philippe Mathieu-Daudé
2025-06-06 16:18 ` Pierrick Bouvier
2025-06-05 19:35 ` [RFC PATCH 4/4] buildsys: Prohibit alloca() use on system code Philippe Mathieu-Daudé
2025-06-05 20:53 ` [PATCH 0/4] system: Forbid alloca() Pierrick Bouvier
2025-06-06 8:37 ` Peter Maydell
2025-06-06 8:53 ` Philippe Mathieu-Daudé
2025-06-06 8:44 ` Alex Bennée
2025-06-09 13:46 ` Stefan Hajnoczi
2025-06-10 9:29 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09c3fae7563bb32237862a71414a14f725d052e4.camel@linux.ibm.com \
--to=milesg@linux.ibm.com \
--cc=berrange@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=stefanb@linux.vnet.ibm.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).