From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33930C54E4A for ; Tue, 27 Feb 2024 12:11:00 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rewHW-0003sn-Ru; Tue, 27 Feb 2024 07:09:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rewHU-0003sW-73 for qemu-devel@nongnu.org; Tue, 27 Feb 2024 07:09:56 -0500 Received: from mgamail.intel.com ([192.198.163.13]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rewHR-0003fc-KY for qemu-devel@nongnu.org; Tue, 27 Feb 2024 07:09:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709035794; x=1740571794; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=LcBc2xeaJTxXGy7RWmHyOmRx6954AwBxc525s+oHjKc=; b=cgByaTdOEmbUjCGsqVeh0Wtg2Nr/+sJihS0//UxTljeqKVg+Z5F8xw6G l6iZvCwc/QmYVTLnxUEzY2bj6rlp9lfN/lxpbInJnz6a9VwPCAAlsyKZb I0hBs2pXQvux7O3R+9xJBtHAwlCikNWUYibvSrsr8k3boTLFWhYa+P+XP DWEqNRgeemcJU+vwhfYhXGQKqI2Sn8TEhDxGwWqZ6xq/Qs2tfTw4PWFzM d2AP6WxR7zNZ0LGJ+Bz1Dy4fvINJEdt6tkvIaa/LnTf5f4BZ0ZNsx5+c3 vNfHF7KOcOpkGJMHs6dHxhvxAMQIQu7afOVbPiQI9vsZo2rqVf3wHPF+J w==; X-IronPort-AV: E=McAfee;i="6600,9927,10996"; a="6319314" X-IronPort-AV: E=Sophos;i="6.06,187,1705392000"; d="scan'208";a="6319314" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2024 04:09:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,187,1705392000"; d="scan'208";a="7001290" Received: from xiaoyaol-hp-g830.ccr.corp.intel.com (HELO [10.125.243.127]) ([10.125.243.127]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2024 04:09:44 -0800 Message-ID: <09c5fd9b-be96-45b6-b48e-772d5b5aad16@intel.com> Date: Tue, 27 Feb 2024 20:09:41 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 53/66] i386/tdx: Wire TDX_REPORT_FATAL_ERROR with GuestPanic facility Content-Language: en-US To: Markus Armbruster Cc: Paolo Bonzini , David Hildenbrand , Igor Mammedov , "Michael S . Tsirkin" , Marcel Apfelbaum , Richard Henderson , Peter Xu , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , Cornelia Huck , =?UTF-8?Q?Daniel_P=2EBerrang=C3=A9?= , Eric Blake , Marcelo Tosatti , qemu-devel@nongnu.org, kvm@vger.kernel.org, Michael Roth , Sean Christopherson , Claudio Fontana , Gerd Hoffmann , Isaku Yamahata , Chenyi Qiang References: <20240125032328.2522472-1-xiaoyao.li@intel.com> <20240125032328.2522472-54-xiaoyao.li@intel.com> <87v86kehts.fsf@pond.sub.org> <1d7f7c1b-cfaa-4de6-80a0-8d1104440f54@intel.com> <87le76dt1g.fsf@pond.sub.org> From: Xiaoyao Li In-Reply-To: <87le76dt1g.fsf@pond.sub.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=192.198.163.13; envelope-from=xiaoyao.li@intel.com; helo=mgamail.intel.com X-Spam_score_int: -5 X-Spam_score: -0.6 X-Spam_bar: / X-Spam_report: (-0.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.088, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HK_RANDOM_ENVFROM=0.599, HK_RANDOM_FROM=0.999, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 2/27/2024 7:51 PM, Markus Armbruster wrote: > Xiaoyao Li writes: > >> On 2/19/2024 8:53 PM, Markus Armbruster wrote: >>> Xiaoyao Li writes: >>> >>>> Integrate TDX's TDX_REPORT_FATAL_ERROR into QEMU GuestPanic facility >>>> >>>> Originated-from: Isaku Yamahata >>>> Signed-off-by: Xiaoyao Li >>>> --- >>>> Changes in v4: >>>> - refine the documentation; (Markus) >>>> >>>> Changes in v3: >>>> - Add docmentation of new type and struct; (Daniel) >>>> - refine the error message handling; (Daniel) >>>> --- >>>> qapi/run-state.json | 28 ++++++++++++++++++++-- >>>> system/runstate.c | 54 +++++++++++++++++++++++++++++++++++++++++++ >>>> target/i386/kvm/tdx.c | 24 ++++++++++++++++++- >>>> 3 files changed, 103 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/qapi/run-state.json b/qapi/run-state.json >>>> index 08bc99cb8561..5429116679e3 100644 >>>> --- a/qapi/run-state.json >>>> +++ b/qapi/run-state.json >>>> @@ -485,10 +485,12 @@ >>>> # >>>> # @s390: s390 guest panic information type (Since: 2.12) >>>> # >>>> +# @tdx: tdx guest panic information type (Since: 8.2) >>>> +# >>>> # Since: 2.9 >>>> ## >>>> { 'enum': 'GuestPanicInformationType', >>>> - 'data': [ 'hyper-v', 's390' ] } >>>> + 'data': [ 'hyper-v', 's390', 'tdx' ] } >>>> >>>> ## >>>> # @GuestPanicInformation: >>>> @@ -503,7 +505,8 @@ >>>> 'base': {'type': 'GuestPanicInformationType'}, >>>> 'discriminator': 'type', >>>> 'data': {'hyper-v': 'GuestPanicInformationHyperV', >>>> - 's390': 'GuestPanicInformationS390'}} >>>> + 's390': 'GuestPanicInformationS390', >>>> + 'tdx' : 'GuestPanicInformationTdx'}} >>>> >>>> ## >>>> # @GuestPanicInformationHyperV: >>>> @@ -566,6 +569,27 @@ >>>> 'psw-addr': 'uint64', >>>> 'reason': 'S390CrashReason'}} >>>> >>>> +## >>>> +# @GuestPanicInformationTdx: >>>> +# >>>> +# TDX Guest panic information specific to TDX GCHI >>>> +# TDG.VP.VMCALL. >>>> +# >>>> +# @error-code: TD-specific error code >>> >>> Where could a user find information on these error codes? >> >> TDX GHCI (Guset-host-communication-Interface)spec. It defines all the >> TDVMCALL leaves. >> >> 0: panic; >> 0x1 - 0xffffffff: reserved. > > Would it make sense to add a reference? https://cdrdv2.intel.com/v1/dl/getContent/726792 >>>> +# >>>> +# @gpa: guest-physical address of a page that contains additional >>>> +# error data, in forms of zero-terminated string. >>> >>> "in the form of a zero-terminated string" >> >> fixed. >> >>>> +# >>>> +# @message: Human-readable error message provided by the guest. Not >>>> +# to be trusted. >>> >>> How is this message related to the one pointed to by @gpa? >> >> In general, @message contains a brief message of the error. While @gpa >> (when valid) contains a verbose message. >> >> The reason why we need both is because sometime when TD guest hits a >> fatal error, its memory may get corrupted so we cannot pass information >> via @gpa. Information in @message is passed through GPRs. > > Well, we do pass information via @gpa, always. I guess it page's > contents can be corrupted. No. It's not always. the bit 63 of the error code is "GPA valid" bit. @gpa is valid only when bit 63 of error code is 1. And current Linux TD guest implementation doesn't use @gpa at all. https://github.com/torvalds/linux/blob/45ec2f5f6ed3ec3a79ba1329ad585497cdcbe663/arch/x86/coco/tdx/tdx.c#L131 > Perhaps something like > > # @message: Human-readable error message provided by the guest. Not > # to be trusted. > # > # @gpa: guest-physical address of a page that contains more verbose > # error information, as zero-terminated string. Note that guest > # memory corruption can corrupt the page's contents. > >>>> +# >>>> +# Since: 9.0 >>>> +## >>>> +{'struct': 'GuestPanicInformationTdx', >>>> + 'data': {'error-code': 'uint64', >>>> + 'gpa': 'uint64', >>>> + 'message': 'str'}} > > Note that my proposed doc string has the members in a different order. > Recommend to use the same order here. > >>>> + >>>> ## >>>> # @MEMORY_FAILURE: >>>> # >>> >>> [...] >>> >