From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51366) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d5xVs-0006cW-6h for qemu-devel@nongnu.org; Wed, 03 May 2017 12:52:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d5xVo-00079I-2p for qemu-devel@nongnu.org; Wed, 03 May 2017 12:52:28 -0400 Received: from smtp.ctxuk.citrix.com ([185.25.65.24]:43973 helo=SMTP.EU.CITRIX.COM) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1d5xVn-00078J-PM for qemu-devel@nongnu.org; Wed, 03 May 2017 12:52:24 -0400 From: Paul Durrant Date: Wed, 3 May 2017 16:52:21 +0000 Message-ID: <09c8c19508f74b42ac6261944ca2d097@AMSPEX02CL03.citrite.net> References: <03cfd81856554ecd91c0c317353e819b@AMSPEX02CL03.citrite.net> <51ac3ff38f464abfb98928e6fb959bf7@AMSPEX02CL03.citrite.net> <6738c7d96a1c476187f69616f25b28d1@AMSPEX02CL03.citrite.net> <20170503164838.GB1553@perard.uk.xensource.com> In-Reply-To: <20170503164838.GB1553@perard.uk.xensource.com> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [Qemu-devel] QEMU build breakage on ARM against Xen 4.9 caused by libxendevicemodel List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Perard , Stefano Stabellini Cc: "qemu-devel@nongnu.org" , Wei Liu , "xen-devel@lists.xenproject.org" > -----Original Message----- > From: Anthony PERARD [mailto:anthony.perard@citrix.com] > Sent: 03 May 2017 17:49 > To: Stefano Stabellini > Cc: Paul Durrant ; qemu-devel@nongnu.org; Wei > Liu ; xen-devel@lists.xenproject.org > Subject: Re: QEMU build breakage on ARM against Xen 4.9 caused by > libxendevicemodel >=20 > On Thu, Apr 20, 2017 at 11:05:33AM -0700, Stefano Stabellini wrote: > > On Thu, 20 Apr 2017, Paul Durrant wrote: > > > I think xencall should be part of the base xen_stable_libs anyway. > > > > Yes, you are right. However I noticed that -lxencall needs to come afte= r > > -lxendevicemodel. So, I'll have to move -lxendevicemodel before > > $xen_stable_libs, see below. I'll merge this patch into "configure: > > detect presence of libxendevicemodel", if that's OK. > > > > diff --git a/configure b/configure > > index 99d6cbc..3133ef8 100755 > > --- a/configure > > +++ b/configure > > @@ -1992,7 +1992,7 @@ if test "$xen" !=3D "no" ; then > > else > > > > xen_libs=3D"-lxenstore -lxenctrl -lxenguest" > > - xen_stable_libs=3D"-lxenforeignmemory -lxengnttab -lxenevtchn" > > + xen_stable_libs=3D"-lxencall -lxenforeignmemory -lxengnttab - > lxenevtchn" > > > > # First we test whether Xen headers and libraries are available. > > # If no, we are done and there is no Xen support. > > @@ -2027,9 +2027,9 @@ int main(void) { > > return 0; > > } > > EOF > > - compile_prog "" "$xen_libs $xen_stable_libs -lxendevicemodel" > > + compile_prog "" "$xen_libs -lxendevicemodel $xen_stable_libs" > > then > > - xen_stable_libs=3D"$xen_stable_libs -lxendevicemodel" > > + xen_stable_libs=3D"-lxendevicemodel $xen_stable_libs" > > xen_ctrl_version=3D40900 > > xen=3Dyes > > elif >=20 > Hey, now that this patch is merged, xen.git fail to build QEMU. (osstest > qemu-mainline branch fail.) >=20 > That's because -lxencall is not found because -L$path_to_libxencall is > missing in xen.git. >=20 > But I've notice something else, libxendevicemodel.so is not linked > against libxencall, that might be the root of the issues on arm. > (libxenctrl.so is linked against libxencall.) >=20 > Thought? >=20 That's definitely an oversight. It should be linked against libxencall. Paul >=20 > We probably need this patch in xen: >=20 > diff --git a/tools/libs/devicemodel/Makefile > b/tools/libs/devicemodel/Makefile > index 55626a5049..81fa5a4ac4 100644 > --- a/tools/libs/devicemodel/Makefile > +++ b/tools/libs/devicemodel/Makefile > @@ -63,7 +63,7 @@ libxendevicemodel.so.$(MAJOR): > libxendevicemodel.so.$(MAJOR).$(MINOR) > $(SYMLINK_SHLIB) $< $@ >=20 > libxendevicemodel.so.$(MAJOR).$(MINOR): $(PIC_OBJS) > libxendevicemodel.map > - $(CC) $(LDFLAGS) $(PTHREAD_LDFLAGS) -Wl,$(SONAME_LDFLAG) - > Wl,libxendevicemodel.so.$(MAJOR) $(SHLIB_LDFLAGS) -o $@ $(PIC_OBJS) > $(LDLIBS_libxentoollog) $(APPEND_LDFLAGS) > + $(CC) $(LDFLAGS) $(PTHREAD_LDFLAGS) -Wl,$(SONAME_LDFLAG) - > Wl,libxendevicemodel.so.$(MAJOR) $(SHLIB_LDFLAGS) -o $@ $(PIC_OBJS) > $(LDLIBS_libxentoollog) $(LDLIBS_libxencall) $(APPEND_LDFLAGS) >=20 > .PHONY: install > install: build >=20 > -- > Anthony PERARD