From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Alistair Francis <alistair.francis@xilinx.com>,
Igor Mitsyanko <i.mitsyanko@gmail.com>,
QEMU Developers <qemu-devel@nongnu.org>,
"Edgar E . Iglesias" <edgar.iglesias@xilinx.com>,
Prasad J Pandit <pjp@fedoraproject.org>,
Andrzej Zaborowski <balrogg@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v4 09/11] sdcard: display protocol used when tracing
Date: Sat, 3 Mar 2018 09:09:50 -0300 [thread overview]
Message-ID: <09d874b7-ad7d-06cd-7d04-ff57265cb2fd@amsat.org> (raw)
In-Reply-To: <CAFEAcA8YipVxDHsKHYE=8kN+Nrsvs1Cp7OavYL2Am=6gozh_AA@mail.gmail.com>
On 02/22/2018 10:02 AM, Peter Maydell wrote:
> On 15 February 2018 at 22:05, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>> put the function in sdmmc-common.c since we will reuse it in hw/sd/core.c
>>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> Commit message talks about a function but the patch doesn't
> add any new functions ? (Also, sentences should start with
I suppose I mistaken the commit message when I rebased, this message
belongs to the previous commit.
> a capital letter and end with a full stop, please.)
Got it!
> Otherwise
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Thanks!
next prev parent reply other threads:[~2018-03-03 12:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 22:05 [Qemu-devel] [PATCH v4 00/11] SDCard: housekeeping, add tracing (part 4) Philippe Mathieu-Daudé
2018-02-15 22:05 ` [Qemu-devel] [PATCH v4 01/11] sdcard: reorder SDState struct members Philippe Mathieu-Daudé
2018-02-15 22:05 ` [Qemu-devel] [PATCH v4 02/11] sdcard: replace DPRINTF() by trace events Philippe Mathieu-Daudé
2018-02-16 21:01 ` Alistair Francis
2018-02-15 22:05 ` [Qemu-devel] [PATCH v4 03/11] sdcard: add a trace event for command responses Philippe Mathieu-Daudé
2018-02-27 2:14 ` Alistair Francis
2018-02-15 22:05 ` [Qemu-devel] [PATCH v4 04/11] sdcard: replace fprintf() by qemu_hexdump() Philippe Mathieu-Daudé
2018-02-15 22:05 ` [Qemu-devel] [PATCH v4 05/11] sdcard: add more trace events Philippe Mathieu-Daudé
2018-02-15 22:05 ` [Qemu-devel] [PATCH v4 06/11] sdcard: do not trace CMD55 when expecting ACMD Philippe Mathieu-Daudé
2018-02-22 12:01 ` Peter Maydell
2018-03-09 14:07 ` Philippe Mathieu-Daudé
2018-02-15 22:05 ` [Qemu-devel] [PATCH v4 07/11] sdcard: define SDMMC_CMD_MAX instead of using the magic '64' Philippe Mathieu-Daudé
2018-02-15 22:05 ` [Qemu-devel] [PATCH v4 08/11] sdcard: display command name when tracing CMD/ACMD Philippe Mathieu-Daudé
2018-02-22 12:59 ` Peter Maydell
2018-03-09 14:51 ` Philippe Mathieu-Daudé
2018-02-15 22:05 ` [Qemu-devel] [PATCH v4 09/11] sdcard: display protocol used when tracing Philippe Mathieu-Daudé
2018-02-22 13:02 ` Peter Maydell
2018-03-03 12:09 ` Philippe Mathieu-Daudé [this message]
2018-02-15 22:05 ` [Qemu-devel] [PATCH v4 10/11] sdcard: use G_BYTE from cutils Philippe Mathieu-Daudé
2018-02-15 22:05 ` [Qemu-devel] [PATCH v4 11/11] sdcard: use the registerfields API to access the OCR register Philippe Mathieu-Daudé
2018-02-22 9:04 ` [Qemu-devel] [PATCH v4 00/11] SDCard: housekeeping, add tracing (part 4) Philippe Mathieu-Daudé
2018-02-22 13:08 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09d874b7-ad7d-06cd-7d04-ff57265cb2fd@amsat.org \
--to=f4bug@amsat.org \
--cc=alistair.francis@xilinx.com \
--cc=balrogg@gmail.com \
--cc=edgar.iglesias@xilinx.com \
--cc=i.mitsyanko@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=pjp@fedoraproject.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).