From: Eric Blake <eblake@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"qemu-block@nongnu.org" <qemu-block@nongnu.org>
Cc: "mreitz@redhat.com" <mreitz@redhat.com>,
"kwolf@redhat.com" <kwolf@redhat.com>,
"fam@euphon.net" <fam@euphon.net>,
"stefanha@redhat.com" <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 2/2] block/io: use qemu_iovec_init_buf
Date: Wed, 6 Feb 2019 12:33:39 -0600 [thread overview]
Message-ID: <09e2ef0f-7bda-4ad1-c583-b25e5d75a738@redhat.com> (raw)
In-Reply-To: <6cf6c085-3a28-0a7c-75b2-79f181e3ca6e@virtuozzo.com>
[-- Attachment #1: Type: text/plain, Size: 1051 bytes --]
On 2/6/19 12:26 PM, Vladimir Sementsov-Ogievskiy wrote:
>>> shows a lot of, exactly 34 after io.c already updated.
>>> They are in different subsystems, so I think it should be simpler to push this
>>> one as a precedent and example, and then send separate patches (or series)
>>> per-maintainer.
>>
>> Most are block related, so getting it in through the block maintainers
>> is probably the easiest - but you ARE right that one patch per one or
>> two files or two is going to be smartest (otherwise, it gets too big).
>>
>> I'd group qed-table.c and qed.c; and the two hw/ide/ files; resulting in
>> 14 more patches to go.
>>
>
> So, you, think better is to make one common patch set? Ok, I'll do (hmm or start doing)
> it tomorrow as v3 if no other opinions.
Yes, a v3 series of 16 patches for the entire conversion, and cc:
qemu-block, should be sufficient. Looking forward to seeing v3.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2019-02-06 18:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-06 16:53 [Qemu-devel] [PATCH v2 0/2] block: local qiov helper: part I Vladimir Sementsov-Ogievskiy
2019-02-06 16:53 ` [Qemu-devel] [PATCH v2 1/2] block: enhance QEMUIOVector structure Vladimir Sementsov-Ogievskiy
2019-02-06 17:25 ` Eric Blake
2019-02-06 17:50 ` Vladimir Sementsov-Ogievskiy
2019-02-06 16:53 ` [Qemu-devel] [PATCH v2 2/2] block/io: use qemu_iovec_init_buf Vladimir Sementsov-Ogievskiy
2019-02-06 17:32 ` Eric Blake
2019-02-06 18:09 ` Vladimir Sementsov-Ogievskiy
2019-02-06 18:14 ` Eric Blake
2019-02-06 18:26 ` Vladimir Sementsov-Ogievskiy
2019-02-06 18:33 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09e2ef0f-7bda-4ad1-c583-b25e5d75a738@redhat.com \
--to=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).