From: Thomas Huth <thuth@redhat.com>
To: Alistair Francis <alistair.francis@xilinx.com>, qemu-devel@nongnu.org
Cc: alistair23@gmail.com, philippe@mathieu-daude.net, armbru@redhat.com
Subject: Re: [Qemu-devel] [RFC v3 1/3] util/qemu-error: Rename error_print_loc() to be more generic
Date: Thu, 6 Jul 2017 04:36:44 +0200 [thread overview]
Message-ID: <09e83b45-8b34-0639-3626-331fd828fc56@redhat.com> (raw)
In-Reply-To: <170687a37cb487aec9b2b600e563f3d93440b2e8.1499276048.git.alistair.francis@xilinx.com>
On 05.07.2017 19:36, Alistair Francis wrote:
> Rename the error_print_loc() function in preparation for using it to
> print warnings as well.
>
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>
> util/qemu-error.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/util/qemu-error.c b/util/qemu-error.c
> index b331f8f4a4..1c5e35ecdb 100644
> --- a/util/qemu-error.c
> +++ b/util/qemu-error.c
> @@ -146,7 +146,7 @@ const char *error_get_progname(void)
> /*
> * Print current location to current monitor if we have one, else to stderr.
> */
> -static void error_print_loc(void)
> +static void print_loc(void)
> {
> const char *sep = "";
> int i;
> @@ -197,7 +197,7 @@ void error_vreport(const char *fmt, va_list ap)
> g_free(timestr);
> }
>
> - error_print_loc();
> + print_loc();
> error_vprintf(fmt, ap);
> error_printf("\n");
> }
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2017-07-06 2:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 17:36 [Qemu-devel] [RFC v3 0/3] Implement a warning_report function Alistair Francis
2017-07-05 17:36 ` [Qemu-devel] [RFC v3 1/3] util/qemu-error: Rename error_print_loc() to be more generic Alistair Francis
2017-07-06 2:36 ` Thomas Huth [this message]
2017-07-05 17:36 ` [Qemu-devel] [RFC v3 2/3] qemu-error: Implement a more generic error reporting Alistair Francis
2017-07-06 2:42 ` Thomas Huth
2017-07-06 6:15 ` Markus Armbruster
2017-07-06 8:07 ` Daniel P. Berrange
2017-07-06 11:27 ` Markus Armbruster
2017-07-06 11:45 ` Daniel P. Berrange
2017-07-06 12:20 ` Markus Armbruster
2017-07-06 13:10 ` Daniel P. Berrange
2017-07-06 14:44 ` Markus Armbruster
2017-07-06 18:45 ` Alistair Francis
2017-07-05 17:36 ` [Qemu-devel] [RFC v3 3/3] char-socket: Report TCP socket waiting as information Alistair Francis
2017-07-06 2:46 ` Thomas Huth
2017-07-06 6:18 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09e83b45-8b34-0639-3626-331fd828fc56@redhat.com \
--to=thuth@redhat.com \
--cc=alistair.francis@xilinx.com \
--cc=alistair23@gmail.com \
--cc=armbru@redhat.com \
--cc=philippe@mathieu-daude.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).