From: Programmingkid <programmingkidx@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Markus Armbruster <armbru@redhat.com>,
qemu-devel qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2] MacKeys.h: initial commit
Date: Wed, 2 Mar 2016 12:13:32 -0500 [thread overview]
Message-ID: <0C7DE8BA-FD0A-4801-8CEC-23643281934A@gmail.com> (raw)
In-Reply-To: <CAFEAcA8uKQTpKZtfHPzpex0cG=wHgW34M5XEDoukLm8ckLvBTg@mail.gmail.com>
On Mar 2, 2016, at 11:45 AM, Peter Maydell wrote:
> On 2 March 2016 at 15:55, Markus Armbruster <armbru@redhat.com> wrote:
>> I'd call it mac-keys.h. mackeys.h would be okay. There's enough
>> precedence for '_' in file names to justify mac_keys.h, but I personally
>> dislike that.
>
> Calling it adb-keys.h would make it clearer that what we're defining
> here are the scancodes for ADB keyboards. (They happen to be the
> same as the Cocoa/Carbon GUI keycodes for modern macs with non
> ADB keyboards, but this is just a historical effect.)
Did you want me to change all the constants to something other than MAC_KEY_ ?
I could be ADB_KEY_ for all the keys if you want.
next prev parent reply other threads:[~2016-03-02 17:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 1:58 [Qemu-devel] [PATCH v2] MacKeys.h: initial commit Programmingkid
2016-03-02 9:32 ` Markus Armbruster
2016-03-02 14:49 ` Programmingkid
2016-03-02 15:55 ` Markus Armbruster
2016-03-02 16:01 ` Eric Blake
2016-03-02 16:45 ` Peter Maydell
2016-03-02 17:04 ` Programmingkid
2016-03-02 17:13 ` Programmingkid [this message]
2016-03-02 17:33 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0C7DE8BA-FD0A-4801-8CEC-23643281934A@gmail.com \
--to=programmingkidx@gmail.com \
--cc=armbru@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).