From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 4/4] qapi-types.py: Drop unused variable
Date: Mon, 17 Oct 2011 16:29:13 -0500 [thread overview]
Message-ID: <0Mclzd-1RXrGl2gNN-00HiTw@mrelay.perfora.net> (raw)
In-Reply-To: <1318865377-3328-5-git-send-email-lcapitulino@redhat.com>
Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>
On Mon, 17 Oct 2011 13:29:37 -0200, Luiz Capitulino <lcapitulino@redhat.com> wrote:
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
> scripts/qapi-types.py | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py
> index 4a2ddc4..28d7f01 100644
> --- a/scripts/qapi-types.py
> +++ b/scripts/qapi-types.py
> @@ -65,7 +65,6 @@ def generate_enum_lookup(name, values):
> const char *%(name)s_lookup[] = {
> ''',
> name=name)
> - i = 0
> for value in values:
> ret += mcgen('''
> "%(value)s",
> --
> 1.7.7.rc3
>
--
Sincerely,
Mike Roth
IBM Linux Technology Center
prev parent reply other threads:[~2011-10-17 21:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-17 15:29 [Qemu-devel] [PATCH v1 0/4]: QAPI: Small fixes for qapi-types.py Luiz Capitulino
2011-10-17 15:29 ` [Qemu-devel] [PATCH 1/4] qapi-types.py: Add a main() like function Luiz Capitulino
2011-10-17 21:19 ` Michael Roth
2011-10-17 15:29 ` [Qemu-devel] [PATCH 2/4] qapi-types.py: Don't build paths by hand Luiz Capitulino
2011-10-17 21:20 ` Michael Roth
2011-10-17 15:29 ` [Qemu-devel] [PATCH 3/4] qapi-types.py: Fail gracefully if out dir is not specified Luiz Capitulino
2011-10-17 21:27 ` Michael Roth
2011-10-18 12:31 ` Luiz Capitulino
2011-10-17 15:29 ` [Qemu-devel] [PATCH 4/4] qapi-types.py: Drop unused variable Luiz Capitulino
2011-10-17 21:29 ` Michael Roth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0Mclzd-1RXrGl2gNN-00HiTw@mrelay.perfora.net \
--to=mdroth@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).