From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
"patches@linaro.org" <patches@linaro.org>,
Eduardo Habkost <ehabkost@redhat.com>,
Marcel Apfelbaum <marcel@redhat.com>,
Igor Mammedov <imammedo@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 02/11] memory: Document that the RAM MR initializers do not handle migration
Date: Mon, 10 Jul 2017 12:05:54 +0200 [thread overview]
Message-ID: <0a225c8e-1dc6-0709-f431-0b918e5d47d2@redhat.com> (raw)
In-Reply-To: <CAFEAcA_UBEY7pwtnTpCaX27e4sRHj_jioUq=7f1_UhDidNAkGw@mail.gmail.com>
On 10/07/2017 12:04, Peter Maydell wrote:
> On 10 July 2017 at 11:01, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>
>>
>> On 07/07/2017 16:42, Peter Maydell wrote:
>>> @@ -522,6 +537,9 @@ void memory_region_init_ram_ptr(MemoryRegion *mr,
>>> * @name: the name of the region.
>>> * @size: size of the region.
>>> * @ptr: memory to be mapped; must contain at least @size bytes.
>>> + *
>>> + * Note that this function does not do anything to cause the data in the
>>> + * RAM memory region to be migrated; that is the responsibility of the caller.
>>
>> Perhaps add a note that it rarely makes sense for this function?
>
> Well, we have 4 callers of this function, and 3 of those
> register the RAM for migration, so the rare case seems to be
> the "don't need to handle migration"...
Oops, the diff header is confusing and I didn't notice that when
trimming. My comment refers to RAM device regions.
Paolo
next prev parent reply other threads:[~2017-07-10 10:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-07 14:42 [Qemu-devel] [PATCH 00/11] Make memory_region_init_ram() and friends handle migration Peter Maydell
2017-07-07 14:42 ` [Qemu-devel] [PATCH 01/11] include/hw/boards.h: Document memory_region_allocate_system_memory() Peter Maydell
2017-07-10 9:42 ` Paolo Bonzini
2017-07-07 14:42 ` [Qemu-devel] [PATCH 02/11] memory: Document that the RAM MR initializers do not handle migration Peter Maydell
2017-07-10 10:01 ` Paolo Bonzini
2017-07-10 10:04 ` Peter Maydell
2017-07-10 10:05 ` Paolo Bonzini [this message]
2017-07-10 10:08 ` Peter Maydell
2017-07-07 14:42 ` [Qemu-devel] [PATCH 03/11] memory: Rename memory_region_init_ram() to memory_region_init_ram_nomigrate() Peter Maydell
2017-07-07 14:42 ` [Qemu-devel] [PATCH 04/11] memory: Rename memory_region_init_rom() and _rom_device() to _nomigrate() Peter Maydell
2017-07-07 14:42 ` [Qemu-devel] [PATCH 05/11] memory.h: Add memory_region_init_{ram, rom, rom_device}() handling migration Peter Maydell
2017-07-07 14:42 ` [Qemu-devel] [PATCH 06/11] scripts/coccinelle/memory-region-init-ram.cocci: New script Peter Maydell
2017-07-07 14:42 ` [Qemu-devel] [PATCH 07/11] hw: Use new memory_region_init_{ram, rom, rom_device}() functions Peter Maydell
2017-07-07 14:42 ` [Qemu-devel] [PATCH 08/11] hw/block/pflash_cfi01, pflash_cfi02: Use memory_region_init_rom_device() Peter Maydell
2017-07-07 14:42 ` [Qemu-devel] [PATCH 09/11] hw/pci/pci.c: Use memory_region_init_rom() Peter Maydell
2017-07-07 14:42 ` [Qemu-devel] [PATCH 10/11] hw/display/qxl.c Use memory_region_init_ram() Peter Maydell
2017-07-07 14:42 ` [Qemu-devel] [PATCH 11/11] docs/devel/memory.txt: Add section about RAM migration Peter Maydell
2017-07-10 10:05 ` [Qemu-devel] [PATCH 00/11] Make memory_region_init_ram() and friends handle migration Paolo Bonzini
2017-07-14 17:01 ` Peter Maydell
2017-07-17 9:01 ` Peter Maydell
2017-07-22 4:47 ` Philippe Mathieu-Daudé
2017-07-23 19:58 ` Peter Maydell
2017-07-25 5:28 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a225c8e-1dc6-0709-f431-0b918e5d47d2@redhat.com \
--to=pbonzini@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=marcel@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).