From: "Volker Rümelin" <vr_qemu@t-online.de>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "Christian Schoenebeck" <qemu_oss@crudebyte.com>,
"Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Daniel P. Berrangé" <berrange@redhat.com>,
qemu-devel@nongnu.org
Subject: [PATCH v2 00/11] audio: more improvements
Date: Sat, 21 Jan 2023 10:45:59 +0100 [thread overview]
Message-ID: <0a4007dc-e11c-f16e-0e21-dbc4e60caa59@t-online.de> (raw)
A few patches from my audio patch queue.
Patches 1 - 2:
If a guest selects an unsupported sample rate, an error message is
currently shown. The first patch takes care to suppress the error
message and reports with the qemu_log_mask(LOG_UNIMP, ...) function that
this is not supported. The second patch is needed because there are two
code paths to reach the qemu_log_mask() function in the
audio_pcm_sw_alloc_resources_* functions. The second path prints an
additional error message up to now.
For more background information:
https://lists.nongnu.org/archive/html/qemu-devel/2022-10/msg04940.html
Patches 3 - 4:
General improvements.
Patches 5 - 9:
These patches remove the audio_calloc() function. The GLib g_new0 macro
is a better replacement for audio_calloc(). There's one exception where
g_malloc0() fits better.
Patches 10 - 11:
Audio playback and recording with the ALSA audio backend currently
doesn't work well with the default audio settings.
v2: Address Daniel's comments
[PATCH v2 07/11] audio/audio_template: use g_malloc0() to replace
audio_calloc()
The n_bytes argument of g_malloc0() is now always > 0 at this call site.
[PATCH v2 08/11] audio/audio_template: use g_new0() to replace
audio_calloc()
Check samples for negative values. It's possible to have negative
samples due to overflows or unsigned to signed conversions. Patch 01/11
takes care of samples == 0.
Volker Rümelin (11):
audio: log unimplemented audio device sample rates
audio: don't show unnecessary error messages
audio: rename hardware store to backend
audio: remove unused #define AUDIO_STRINGIFY
audio/mixeng: use g_new0() instead of audio_calloc()
audio/alsaaudio: use g_new0() instead of audio_calloc()
audio/audio_template: use g_malloc0() to replace audio_calloc()
audio/audio_template: use g_new0() to replace audio_calloc()
audio: remove audio_calloc() function
alsaaudio: change default playback settings
alsaaudio: reintroduce default recording settings
audio/alsaaudio.c | 27 ++++++-----------
audio/audio.c | 26 +---------------
audio/audio_int.h | 8 ++---
audio/audio_template.h | 68 ++++++++++++++++++++++--------------------
audio/mixeng.c | 7 +----
5 files changed, 48 insertions(+), 88 deletions(-)
--
2.35.3
next reply other threads:[~2023-01-21 9:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-21 9:45 Volker Rümelin [this message]
2023-01-21 9:47 ` [PATCH v2 01/11] audio: log unimplemented audio device sample rates Volker Rümelin
2023-01-21 9:47 ` [PATCH v2 02/11] audio: don't show unnecessary error messages Volker Rümelin
2023-01-21 9:47 ` [PATCH v2 03/11] audio: rename hardware store to backend Volker Rümelin
2023-01-23 7:33 ` Philippe Mathieu-Daudé
2023-01-21 9:47 ` [PATCH v2 04/11] audio: remove unused #define AUDIO_STRINGIFY Volker Rümelin
2023-01-21 9:47 ` [PATCH v2 05/11] audio/mixeng: use g_new0() instead of audio_calloc() Volker Rümelin
2023-01-21 9:47 ` [PATCH v2 06/11] audio/alsaaudio: " Volker Rümelin
2023-01-21 9:47 ` [PATCH v2 07/11] audio/audio_template: use g_malloc0() to replace audio_calloc() Volker Rümelin
2023-01-23 11:03 ` Daniel P. Berrangé
2023-01-21 9:47 ` [PATCH v2 08/11] audio/audio_template: use g_new0() " Volker Rümelin
2023-01-23 11:04 ` Daniel P. Berrangé
2023-01-21 9:47 ` [PATCH v2 09/11] audio: remove audio_calloc() function Volker Rümelin
2023-01-21 9:47 ` [PATCH v2 10/11] alsaaudio: change default playback settings Volker Rümelin
2023-01-23 7:43 ` Philippe Mathieu-Daudé
2023-01-24 7:34 ` Volker Rümelin
2023-01-21 9:47 ` [PATCH v2 11/11] alsaaudio: reintroduce default recording settings Volker Rümelin
2023-01-23 7:44 ` Philippe Mathieu-Daudé
2023-01-31 14:51 ` [PATCH v2 00/11] audio: more improvements Marc-André Lureau
2023-03-05 17:35 ` Volker Rümelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a4007dc-e11c-f16e-0e21-dbc4e60caa59@t-online.de \
--to=vr_qemu@t-online.de \
--cc=berrange@redhat.com \
--cc=kraxel@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).