From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Huth <thuth@redhat.com>, Joelle van Dyne <j@getutm.app>,
BALATON Zoltan <balaton@eik.bme.hu>
Cc: "Daniel P. Berrange" <berrange@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH v2 2/9] configure: cross-compiling without cross_prefix
Date: Tue, 20 Oct 2020 10:34:59 +0200 [thread overview]
Message-ID: <0a7b6404-55db-ec3f-2b56-1d695f840475@redhat.com> (raw)
In-Reply-To: <d27c852c-b982-9b58-fbff-1bfc3d075e94@redhat.com>
On 20/10/20 07:15, Thomas Huth wrote:
>>>>>> + ;;
>>>>>> + --enable-cross-compile) cross_compile="yes"
>>>>>> + ;;
>>>>>> + --disable-cross-compile) cross_compile="no"
>>>>>
>>>>> Can't you simply use --cros-prefix="" instead?
>>>>
>>>> I mean, still introduce the "cross_compile=yes" variable, just omit the new
>>>> options.
>>>
>>> That seems less intuitive for people trying to find this option. If --help
>>> lists --enable-cross-compile I can guess what that means but there's no
>>> way I could guess --cros-prefix="" unless I've been told or searched and
>>> stumbled upon it. So unless it's a big problem I like the explicit options
>>> better. Or is that a convention in other projects to use empty prefix to
>>> enable cross compile that I don't know about?
>
> I don't think that --cross-prefix is a "standard" option... Most other
> (GNU-tools related) projects use "--build" and "--host" instead... so I
> guess we're free to chose here. Let's see whether other people here have an
> opionion on this...
Yeah, the way GNU tools do it is that you specify --build and --host,
and --host triggers cross compilation. I'm not sure how they'd handle
the situation where the cross prefix is empty.
For QEMU, I agree with Thomas that --cross-prefix="" is enough.
Paolo
next prev parent reply other threads:[~2020-10-20 8:36 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 1:39 [PATCH v2 0/9] iOS and Apple Silicon host support Joelle van Dyne
2020-10-19 1:39 ` [PATCH v2 1/9] configure: option to disable host block devices Joelle van Dyne
2020-10-19 1:39 ` [PATCH v2 2/9] configure: cross-compiling without cross_prefix Joelle van Dyne
2020-10-19 8:07 ` Thomas Huth
2020-10-19 8:09 ` Thomas Huth
2020-10-19 11:24 ` BALATON Zoltan via
2020-10-19 22:24 ` Joelle van Dyne
2020-10-20 5:15 ` Thomas Huth
2020-10-20 8:34 ` Paolo Bonzini [this message]
2020-10-25 19:24 ` Joelle van Dyne
2020-10-26 7:54 ` Paolo Bonzini
2020-10-26 15:33 ` Joelle van Dyne
2020-10-26 16:15 ` Paolo Bonzini
2020-10-26 18:51 ` Thomas Huth
2020-10-19 1:39 ` [PATCH v2 3/9] qemu: add support for iOS host Joelle van Dyne
2020-10-19 1:39 ` [PATCH v2 4/9] coroutine: add libucontext as external library Joelle van Dyne
2020-10-19 1:39 ` [PATCH v2 5/9] tcg: add const hints for code pointers Joelle van Dyne
2020-10-19 23:19 ` Richard Henderson
2020-10-19 23:26 ` Joelle van Dyne
2020-10-19 23:27 ` Richard Henderson
2020-10-19 23:36 ` Joelle van Dyne
2020-10-19 23:41 ` Richard Henderson
2020-10-19 1:39 ` [PATCH v2 6/9] tcg: implement mirror mapped JIT for iOS Joelle van Dyne
2020-10-19 11:48 ` BALATON Zoltan via
2020-10-19 22:39 ` Joelle van Dyne
2020-10-19 23:45 ` BALATON Zoltan via
2020-10-20 0:19 ` Richard Henderson
2020-10-25 19:46 ` Joelle van Dyne
2020-10-25 20:51 ` Joelle van Dyne
2020-10-25 23:43 ` Alexander Bulekov
2020-10-19 1:39 ` [PATCH v2 7/9] tcg: mirror mapping RWX pages for iOS optional Joelle van Dyne
2020-10-20 1:27 ` Richard Henderson
2020-10-19 1:39 ` [PATCH v2 8/9] tcg: support JIT on Apple Silicon Joelle van Dyne
2020-10-19 1:39 ` [PATCH v2 9/9] block: check availablity for preadv/pwritev on mac Joelle van Dyne
2020-10-19 8:27 ` Thomas Huth
2020-10-19 22:20 ` Joelle van Dyne
2020-10-20 5:19 ` Thomas Huth
2020-10-19 8:29 ` [PATCH v2 0/9] iOS and Apple Silicon host support Thomas Huth
2020-10-26 15:30 ` Joelle van Dyne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a7b6404-55db-ec3f-2b56-1d695f840475@redhat.com \
--to=pbonzini@redhat.com \
--cc=balaton@eik.bme.hu \
--cc=berrange@redhat.com \
--cc=j@getutm.app \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).