From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, Rowan Hart <rowanbhart@gmail.com>
Subject: Re: [PATCH 08/11] plugins: Fix qemu_plugin_read_memory_vaddr parameters
Date: Wed, 12 Feb 2025 08:16:27 +0100 [thread overview]
Message-ID: <0a82687d-08e4-4db8-a7c4-ac7a2faa97b6@linaro.org> (raw)
In-Reply-To: <20250205040341.2056361-9-richard.henderson@linaro.org>
On 5/2/25 05:03, Richard Henderson wrote:
> The declaration uses uint64_t for addr.
>
Fixes: 595cd9ce2ec ("plugins: add plugin API to read guest memory")
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> plugins/api.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/plugins/api.c b/plugins/api.c
> index 4110cfaa23..cf8cdf076a 100644
> --- a/plugins/api.c
> +++ b/plugins/api.c
> @@ -561,7 +561,7 @@ GArray *qemu_plugin_get_registers(void)
> return create_register_handles(regs);
> }
>
> -bool qemu_plugin_read_memory_vaddr(vaddr addr, GByteArray *data, size_t len)
> +bool qemu_plugin_read_memory_vaddr(uint64_t addr, GByteArray *data, size_t len)
> {
> g_assert(current_cpu);
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2025-02-12 7:16 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 4:03 [PATCH 00/11] tcg: Cleanups after disallowing 64-on-32 Richard Henderson
2025-02-05 4:03 ` [PATCH 01/11] tcg: Drop support for two address registers in gen_ldst Richard Henderson
2025-02-13 14:37 ` Philippe Mathieu-Daudé
2025-02-05 4:03 ` [PATCH 02/11] tcg: Merge INDEX_op_qemu_*_{a32,a64}_* Richard Henderson
2025-02-17 14:22 ` Philippe Mathieu-Daudé
2025-02-05 4:03 ` [PATCH 03/11] tcg/arm: Drop addrhi from prepare_host_addr Richard Henderson
2025-02-17 12:12 ` Philippe Mathieu-Daudé
2025-02-17 16:44 ` Richard Henderson
2025-02-05 4:03 ` [PATCH 04/11] tcg/i386: " Richard Henderson
2025-02-13 14:35 ` Philippe Mathieu-Daudé
2025-02-05 4:03 ` [PATCH 05/11] tcg/mips: " Richard Henderson
2025-02-13 14:33 ` Philippe Mathieu-Daudé
2025-02-05 4:03 ` [PATCH 06/11] tcg/ppc: " Richard Henderson
2025-02-13 14:34 ` Philippe Mathieu-Daudé
2025-02-05 4:03 ` [PATCH 07/11] tcg: Replace addr{lo, hi}_reg with addr_reg in TCGLabelQemuLdst Richard Henderson
2025-02-12 7:14 ` Philippe Mathieu-Daudé
2025-02-05 4:03 ` [PATCH 08/11] plugins: Fix qemu_plugin_read_memory_vaddr parameters Richard Henderson
2025-02-12 7:16 ` Philippe Mathieu-Daudé [this message]
2025-02-05 4:03 ` [PATCH 09/11] accel/tcg: Fix tlb_set_page_with_attrs, tlb_set_page Richard Henderson
2025-02-12 7:22 ` Philippe Mathieu-Daudé
2025-02-12 18:21 ` Richard Henderson
2025-02-17 7:32 ` Philippe Mathieu-Daudé
2025-02-05 4:03 ` [PATCH 10/11] include/exec: Change vaddr to uintptr_t Richard Henderson
2025-02-12 7:24 ` Philippe Mathieu-Daudé
2025-02-05 4:03 ` [PATCH 11/11] include/exec: Use uintptr_t in CPUTLBEntry Richard Henderson
2025-02-13 14:29 ` Philippe Mathieu-Daudé
2025-02-15 20:06 ` [PATCH 00/11] tcg: Cleanups after disallowing 64-on-32 Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a82687d-08e4-4db8-a7c4-ac7a2faa97b6@linaro.org \
--to=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=rowanbhart@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).