From: Eric Blake <eblake@redhat.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, Laurent Vivier <lvivier@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-4.0 2/5] tests/test-filter: Make tests independent of global_qtest
Date: Thu, 6 Dec 2018 12:43:42 -0600 [thread overview]
Message-ID: <0a8eb2be-30ad-e7e3-65fc-7102890cea60@redhat.com> (raw)
In-Reply-To: <1544114998-1513-3-git-send-email-thuth@redhat.com>
On 12/6/18 10:49 AM, Thomas Huth wrote:
> Apart from using qmp() in the qmp_discard_response() macro, these
> tests do not have any dependencies to the global_qtest variable,
> so we can simply get rid of it here by replacing the qmp() with
> qtest_qmp() in the macro.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/test-filter-mirror.c | 9 +++++----
> tests/test-filter-redirector.c | 16 +++++++++-------
> 2 files changed, 14 insertions(+), 11 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-12-06 18:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 16:49 [Qemu-devel] [PATCH for-4.0 0/5] Make more tests independent of global_qtest Thomas Huth
2018-12-06 16:49 ` [Qemu-devel] [PATCH for-4.0 1/5] tests/boot-serial: Get rid of global_qtest variable Thomas Huth
2018-12-06 18:42 ` Eric Blake
2018-12-06 19:34 ` Thomas Huth
2018-12-06 19:56 ` Eric Blake
2018-12-06 16:49 ` [Qemu-devel] [PATCH for-4.0 2/5] tests/test-filter: Make tests independent of global_qtest Thomas Huth
2018-12-06 18:43 ` Eric Blake [this message]
2018-12-06 16:49 ` [Qemu-devel] [PATCH for-4.0 3/5] tests/machine-none: Make test " Thomas Huth
2018-12-06 18:44 ` Eric Blake
2018-12-06 16:49 ` [Qemu-devel] [PATCH for-4.0 4/5] tests/prom-env: " Thomas Huth
2018-12-06 18:46 ` Eric Blake
2018-12-06 16:49 ` [Qemu-devel] [PATCH for-4.0 5/5] tests/pxe: Make test independent from global_qtest Thomas Huth
2018-12-06 18:50 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a8eb2be-30ad-e7e3-65fc-7102890cea60@redhat.com \
--to=eblake@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).