From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: vsementsov@virtuozzo.com, berrange@redhat.com,
qemu-block@nongnu.org, tao3.xu@intel.com, rjones@redhat.com,
armbru@redhat.com
Subject: Re: [PATCH v2 0/4] improve do_strtosz precision
Date: Mon, 22 Feb 2021 14:19:11 -0600 [thread overview]
Message-ID: <0aaa18a2-eff8-1a50-209a-c03a425b86e9@redhat.com> (raw)
In-Reply-To: <20210211204438.1184395-1-eblake@redhat.com>
On 2/11/21 2:44 PM, Eric Blake wrote:
> Parsing sizes with only 53 bits of precision is surprising; it's time
> to fix it to use a full 64 bits of precision.
>
> v1 was here:
> https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg01800.html
>
> Since then:
> - split testsuite improvements from code changes [Vladimir]
> - more tests for more corner cases [Vladimir, Rich, Dan]
> - fix handling of '123-45' when endptr is non-NULL [Vladimir]
> - fix handling of '1.k'
> - actually enable deprecation of '0x1k' [Vladimir]
> - include missing deprecation text for rounded fractions
> - improved commit messages
>
> I'm still not sure I like patch 4, but it's at least worth considering.
Ping. I've also just realized that this series will fix:
https://bugzilla.redhat.com/show_bug.cgi?id=1909185
"The error message of "qemu-img convert -r" should advertise the correct
maximum number"
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
prev parent reply other threads:[~2021-02-22 20:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 20:44 [PATCH v2 0/4] improve do_strtosz precision Eric Blake
2021-02-11 20:44 ` [PATCH v2 1/4] utils: Enhance testsuite for do_strtosz() Eric Blake
2021-02-23 17:07 ` Daniel P. Berrangé
2021-02-11 20:44 ` [PATCH v2 2/4] utils: Improve qemu_strtosz() to have 64 bits of precision Eric Blake
2021-02-23 17:13 ` Daniel P. Berrangé
2021-02-11 20:44 ` [PATCH v2 3/4] utils: Deprecate hex-with-suffix sizes Eric Blake
2021-02-11 22:59 ` Philippe Mathieu-Daudé
2021-02-23 17:13 ` Daniel P. Berrangé
2021-02-11 20:44 ` [PATCH v2 4/4] utils: Deprecate inexact fractional suffix sizes Eric Blake
2021-02-23 17:20 ` Daniel P. Berrangé
2021-02-24 13:52 ` Eric Blake
2021-02-22 20:19 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0aaa18a2-eff8-1a50-209a-c03a425b86e9@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
--cc=tao3.xu@intel.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).