From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51069) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4PmF-0002wu-4H for qemu-devel@nongnu.org; Tue, 17 Oct 2017 07:11:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e4PmA-0007ax-KW for qemu-devel@nongnu.org; Tue, 17 Oct 2017 07:11:15 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:48988 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e4PmA-0007aT-FU for qemu-devel@nongnu.org; Tue, 17 Oct 2017 07:11:10 -0400 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v9HBAh1V035258 for ; Tue, 17 Oct 2017 07:11:06 -0400 Received: from e06smtp14.uk.ibm.com (e06smtp14.uk.ibm.com [195.75.94.110]) by mx0b-001b2d01.pphosted.com with ESMTP id 2dnfuwa9ax-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Tue, 17 Oct 2017 07:10:58 -0400 Received: from localhost by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 17 Oct 2017 12:10:05 +0100 From: Halil Pasic References: <20171004154144.88995-1-pasic@linux.vnet.ibm.com> <20171004154144.88995-3-pasic@linux.vnet.ibm.com> <7f454872-fae3-35b0-eff4-227b2aa0f77d@linux.vnet.ibm.com> <6c17b274-cd75-7864-94b9-fc8abff1a786@redhat.com> <0120aa4c-ffce-79c0-8c87-c7c1100232eb@redhat.com> <9d77c8e9-f875-4e42-5306-b847904b4a47@linux.vnet.ibm.com> <39f9e450-d618-6c4d-9401-031c5374ed88@redhat.com> <2b90291e-62a8-964f-286a-d8f1594b2d94@linux.vnet.ibm.com> Date: Tue, 17 Oct 2017 13:10:01 +0200 MIME-Version: 1.0 In-Reply-To: <2b90291e-62a8-964f-286a-d8f1594b2d94@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Message-Id: <0ade56a2-046a-6525-f19d-8febebcfde03@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v2 2/8] s390x/css: IO instr handler ending control List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , Cornelia Huck , Dong Jia Shi Cc: Christian Borntraeger , qemu-s390x@nongnu.org, Pierre Morel , qemu-devel@nongnu.org On 10/12/2017 01:44 PM, Halil Pasic wrote: > > > On 10/12/2017 08:58 AM, Thomas Huth wrote: >> On 10.10.2017 13:41, Halil Pasic wrote: [..] >> So yes, please don't do a "typedef unsigned int IOInstEnding" either. I >> think the best match for QEMU would be a >> >> typedef enum IOInstEnding { >> CC_..., >> CC_..., >> CC_..., >> CC_... >> } IOInstEnding; >> > > I also prefer this over #define NAME val. > @Conny @Thomas I'm almost done with v3, but I've realized we did not agree on the names for the enum constants, so before posting something to ugly again, I would like to inquire your opinion. My current version of the enum is the following (but I can easily change to whatever you like with sed): +/* + * IO instructions conclude according this. Currently we have only + * cc codes. Valid values are 0,1,2,3 and the generic semantic for IO instructions + * is described briefly. For more details consult the PoP. + */ +typedef enum IOInstEnding { + IOINST_CC_0 = 0, /* produced expected result */ + IOINST_CC_1 = 1, /* status conditions were present, or alternate result */ + IOINST_CC_2 = 2, /* ineffective, busy with previously initiated function */ + IOINST_CC_3 = 3 /* ineffective, not operational */ +} IOInstEnding; + Alternatives I had in mind are IOINST_CC_0_EXPECTED, IOINST_CC_1_STATUS_PRESENT, IOINST_CC_2_BUSY, IOINST_CC_3_NOT_OPERATIONAL or the same without the numerical code (e.g. just IONIST_CC_EXPECTED). Regards, Halil [..]