From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38244) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b1EFA-0002s4-Fq for qemu-devel@nongnu.org; Fri, 13 May 2016 10:39:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b1EF8-0003qB-6R for qemu-devel@nongnu.org; Fri, 13 May 2016 10:39:07 -0400 References: <1462354765-14037-1-git-send-email-kwolf@redhat.com> <1462354765-14037-8-git-send-email-kwolf@redhat.com> From: Max Reitz Message-ID: <0ae2b471-a304-4bdd-e72f-78bca544c279@redhat.com> Date: Fri, 13 May 2016 16:38:56 +0200 MIME-Version: 1.0 In-Reply-To: <1462354765-14037-8-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DJA1h6HCHeVictBtiiESG7vbJjv5tQ5XD" Subject: Re: [Qemu-devel] [PATCH 07/14] mirror: Use BlockBackend for I/O List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: jcody@redhat.com, jsnow@redhat.com, berto@igalia.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --DJA1h6HCHeVictBtiiESG7vbJjv5tQ5XD From: Max Reitz To: Kevin Wolf , qemu-block@nongnu.org Cc: jcody@redhat.com, jsnow@redhat.com, berto@igalia.com, qemu-devel@nongnu.org Message-ID: <0ae2b471-a304-4bdd-e72f-78bca544c279@redhat.com> Subject: Re: [PATCH 07/14] mirror: Use BlockBackend for I/O References: <1462354765-14037-1-git-send-email-kwolf@redhat.com> <1462354765-14037-8-git-send-email-kwolf@redhat.com> In-Reply-To: <1462354765-14037-8-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 04.05.2016 11:39, Kevin Wolf wrote: > This changes the mirror block job to use the job's BlockBackend for > performing its I/O. job->bs isn't used by the mirroring code any more > afterwards. >=20 > Signed-off-by: Kevin Wolf > --- > block/mirror.c | 75 +++++++++++++++++++++++++++++++-------------------= -------- > blockdev.c | 4 +--- > 2 files changed, 41 insertions(+), 38 deletions(-) >=20 > diff --git a/block/mirror.c b/block/mirror.c > index 23aa10e..dc66340 100644 > --- a/block/mirror.c > +++ b/block/mirror.c > @@ -35,7 +35,7 @@ typedef struct MirrorBuffer { > typedef struct MirrorBlockJob { > BlockJob common; > RateLimit limit; > - BlockDriverState *target; > + BlockBackend *target; > BlockDriverState *base; > /* The name of the graph node to replace */ > char *replaces; > @@ -156,8 +156,8 @@ static void mirror_read_complete(void *opaque, int = ret) > mirror_iteration_done(op, ret); > return; > } > - bdrv_aio_writev(s->target, op->sector_num, &op->qiov, op->nb_secto= rs, > - mirror_write_complete, op); > + blk_aio_writev(s->target, op->sector_num, &op->qiov, op->nb_sector= s, > + mirror_write_complete, op); Or maybe the rest doesn't look so good after all. We don't have this function anymore, I'm afraid. Max > } > =20 > static inline void mirror_clip_sectors(MirrorBlockJob *s, --DJA1h6HCHeVictBtiiESG7vbJjv5tQ5XD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXNecAAAoJEDuxQgLoOKytUe8H/1Yq1Ipr2v7BdYfr18lnMuJc JcQLltWM9B8Ws+ZSwl+KA6H41HTcoSWNVMtFq5bZRsnIcFmyFa5J3UjX8E3jNg8R 2+t5fZ00AyaRZKu2CrC/IFnCaWamu+8OJirvTlQpWuYUF0hq1M4/1kgtZD/wqBOH hWjHHe2ABEFX4YvSqzGpp8g4KZLSt7lnUncZ1qiWiNIslyqKMJoiVmjIFiPLsAaf c7w/PbqnZBhuFs7IYG1TFrPgcRSbkIzZWXrJGlWdzK4nsma6bU4sAT9eJ+60Bw+6 R8eaVA/VQPd5k4jjOy8F/FoYX3CZPBo1o9sOi4PXQMk79zpGqyd0mrhHa+Zla6Q= =71zf -----END PGP SIGNATURE----- --DJA1h6HCHeVictBtiiESG7vbJjv5tQ5XD--