From: Richard Henderson <richard.henderson@linaro.org>
To: Song Gao <gaosong@loongson.cn>, qemu-devel@nongnu.org
Cc: Bibo Mao <maobibo@loongson.cn>
Subject: Re: [PULL v2 04/11] loongarch: add a direct interrupt controller device
Date: Mon, 6 Oct 2025 13:59:41 -0700 [thread overview]
Message-ID: <0ae68db2-190b-4551-965e-67f50541c53a@linaro.org> (raw)
In-Reply-To: <20250928092408.948035-5-gaosong@loongson.cn>
On 9/28/25 02:24, Song Gao wrote:
> Add Loongarch direct interrupt controller device base Definition.
>
> Signed-off-by: Song Gao <gaosong@loongson.cn>
> Reviewed-by: Bibo Mao <maobibo@loongson.cn>
> Message-ID: <20250916122109.749813-5-gaosong@loongson.cn>
> ---
> hw/intc/Kconfig | 3 ++
> hw/intc/loongarch_dintc.c | 68 +++++++++++++++++++++++++++++++
> hw/intc/meson.build | 1 +
> hw/loongarch/Kconfig | 1 +
> include/hw/intc/loongarch_dintc.h | 35 ++++++++++++++++
> 5 files changed, 108 insertions(+)
> create mode 100644 hw/intc/loongarch_dintc.c
> create mode 100644 include/hw/intc/loongarch_dintc.h
...> +static const TypeInfo loongarch_dintc_info = {
> + .name = TYPE_LOONGARCH_DINTC,
> + .parent = TYPE_SYS_BUS_DEVICE,
> + .instance_size = sizeof(LoongArchDINTCState),
> + .instance_init = loongarch_dintc_init,
> + .class_init = loongarch_dintc_class_init,
> +};
Missing .class_size = sizeof(LoongArchDINTCClass).
This clobbers the malloc arena. Irritatingly, it didn't fail when first merged, but now
it's consistent on Alpine. I'll apply the fix to master to get CI in the green.
r~
next prev parent reply other threads:[~2025-10-06 21:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-28 9:23 [PULL v2 00/11] loongarch-to-apply queue Song Gao
2025-09-28 9:23 ` [PULL v2 01/11] target/loongarch: move some machine define to virt.h Song Gao
2025-09-28 9:23 ` [PULL v2 02/11] hw/loongarch: add virt feature dmsi support Song Gao
2025-09-28 9:24 ` [PULL v2 03/11] hw/loongarch: add misc register support dmsi Song Gao
2025-09-28 9:24 ` [PULL v2 04/11] loongarch: add a direct interrupt controller device Song Gao
2025-10-06 20:59 ` Richard Henderson [this message]
2025-09-28 9:24 ` [PULL v2 05/11] target/loongarch: add msg interrupt CSR registers Song Gao
2025-09-28 9:24 ` [PULL v2 06/11] hw/loongarch: DINTC add a MemoryRegion Song Gao
2025-09-28 9:24 ` [PULL v2 07/11] hw/loongarch: Implement dintc realize and unrealize Song Gao
2025-09-28 9:24 ` [PULL v2 08/11] hw/loongarch: Implement dintc set irq Song Gao
2025-09-28 9:24 ` [PULL v2 09/11] target/loongarch: Add CSR_ESTAT.bit15 and CSR_ECFG.bit15 for msg interrupts Song Gao
2025-09-28 9:24 ` [PULL v2 10/11] target/loongarch:Implement csrrd CSR_MSGIR register Song Gao
2025-09-28 9:24 ` [PULL v2 11/11] hw/loongarch: Implement DINTC plug/unplug interfaces Song Gao
2025-09-28 19:25 ` [PULL v2 00/11] loongarch-to-apply queue Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ae68db2-190b-4551-965e-67f50541c53a@linaro.org \
--to=richard.henderson@linaro.org \
--cc=gaosong@loongson.cn \
--cc=maobibo@loongson.cn \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).