qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <lvivier@redhat.com>
To: Jason Wang <jasowang@redhat.com>, qemu-devel@nongnu.org
Cc: Cindy Lu <lulu@redhat.com>
Subject: Re: [PATCH 2/2] vhost-vdpa: improve error reporting
Date: Wed, 9 Sep 2020 10:45:13 +0200	[thread overview]
Message-ID: <0aee9213-ebfb-f8fe-aac7-f9b819f9dfdf@redhat.com> (raw)
In-Reply-To: <38c8862b-e033-1b8c-33bd-5b1f0cd37a01@redhat.com>

On 09/09/2020 03:53, Jason Wang wrote:
> 
> On 2020/9/4 上午2:53, Laurent Vivier wrote:
>> Use Error framework to report the id of the device and the details of
>> the error (vhostdev name and errno).
>>
>> For instance:
>>
>>   qemu-system-x86_64 ... -netdev vhost-vdpa,id=hostnet1 ...
>>   hostnet1: Cannot open '/dev/vhost-vdpa-0': No such file or directory
>>
>> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
>> ---
>>   net/vhost-vdpa.c | 14 ++++++++++----
>>   1 file changed, 10 insertions(+), 4 deletions(-)
> 
> 
> Hi Laurent:
> 
> If you don't mind I will add this patch to v2 of my series[1]

Yes, please. I think it could replace the PATCH 3 of your series.

Thanks,
Laurent



  reply	other threads:[~2020-09-09  8:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-03 18:53 [PATCH 0/2] vhost-vdpa: improve parameters error management Laurent Vivier
2020-09-03 18:53 ` [PATCH 1/2] vhost-vdpa: define and use default value for vhostdev Laurent Vivier
2020-09-09  1:50   ` Jason Wang
2020-09-03 18:53 ` [PATCH 2/2] vhost-vdpa: improve error reporting Laurent Vivier
2020-09-04 13:41   ` Philippe Mathieu-Daudé
2020-09-09  1:53   ` Jason Wang
2020-09-09  8:45     ` Laurent Vivier [this message]
2020-09-04 13:24 ` [PATCH 0/2] vhost-vdpa: improve parameters error management no-reply
2020-09-04 13:28 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0aee9213-ebfb-f8fe-aac7-f9b819f9dfdf@redhat.com \
    --to=lvivier@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=lulu@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).